third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h - Issue 2077413005: Add "alpha" option to PaintWorklet

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h

Issue 2077413005: Add "alpha" option to PaintWorklet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/csspaint/registerPaint.html ('K') | « third_party/WebKit/LayoutTests/platform/linux/csspaint/background-image-alpha-expected.txt ('k') | third_party/WebKit/Source/core/css/CSSPaintValue.h » ('j') | third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CSSPaintImageGenerator_h	5 #ifndef CSSPaintImageGenerator_h

6 #define CSSPaintImageGenerator_h	6 #define CSSPaintImageGenerator_h

7	7

8 #include "core/CSSPropertyNames.h"	8 #include "core/CSSPropertyNames.h"

9 #include "core/CoreExport.h"	9 #include "core/CoreExport.h"

10 #include "platform/geometry/IntSize.h"	10 #include "platform/geometry/IntSize.h"

(...skipping 25 matching lines...) Expand all Loading...
36	36

37 typedef CSSPaintImageGenerator* (CSSPaintImageGeneratorCreateFunction)(cons t String&, Document&, Observer);	37 typedef CSSPaintImageGenerator* (CSSPaintImageGeneratorCreateFunction)(cons t String&, Document&, Observer);

38 static void init(CSSPaintImageGeneratorCreateFunction);	38 static void init(CSSPaintImageGeneratorCreateFunction);

39	39

40 // Invokes the CSS Paint API 'paint' callback. May return a nullptr	40 // Invokes the CSS Paint API 'paint' callback. May return a nullptr

41 // representing an invalid image if an error occurred.	41 // representing an invalid image if an error occurred.

42 virtual PassRefPtr<Image> paint(const LayoutObject&, const IntSize&) = 0;	42 virtual PassRefPtr<Image> paint(const LayoutObject&, const IntSize&) = 0;

43	43

44 virtual const Vector<CSSPropertyID>& nativeInvalidationProperties() const = 0;	44 virtual const Vector<CSSPropertyID>& nativeInvalidationProperties() const = 0;

45 virtual const Vector<AtomicString>& customInvalidationProperties() const = 0 ;	45 virtual const Vector<AtomicString>& customInvalidationProperties() const = 0 ;

	46 virtual bool hasAlphaChannel() const = 0;
	ikilpatrick 2016/06/22 16:00:24 let's just change this to hasAlpha to be consisten let's just change this to hasAlpha to be consistent with CanvasRC2D. Gleb Lanbin 2016/06/22 21:23:45 Done. Show quoted text On 2016/06/22 16:00:24, ikilpatrick wrote: > let's just change this to hasAlpha to be consistent with CanvasRC2D. Done.
46	47

47 DEFINE_INLINE_VIRTUAL_TRACE() { }	48 DEFINE_INLINE_VIRTUAL_TRACE() { }

48 };	49 };

49	50

50 } // namespace blink	51 } // namespace blink

51	52

52 #endif // CSSPaintImageGenerator_h	53 #endif // CSSPaintImageGenerator_h

OLD	NEW