third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp - Issue 2077413005: Add "alpha" option to PaintWorklet

Unified Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

Issue 2077413005: Add "alpha" option to PaintWorklet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set alpha to be true by default Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h ('k') | third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

diff --git a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

index 7da77ddd4e7984fc8c4db12c8f2b3bfb11788796..ba9e7486e5d8f444a03d613f4aed4800ff2de75d 100644

--- a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

+++ b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

@@ -21,15 +21,17 @@

namespace blink {

-CSSPaintDefinition* CSSPaintDefinition::create(ScriptState* scriptState, v8::Local<v8::Function> constructor, v8::Local<v8::Function> paint, Vector<CSSPropertyID>& nativeInvalidationProperties, Vector<AtomicString>& customInvalidationProperties)

+CSSPaintDefinition* CSSPaintDefinition::create(ScriptState* scriptState, v8::Local<v8::Function> constructor, v8::Local<v8::Function> paint, Vector<CSSPropertyID>& nativeInvalidationProperties, Vector<AtomicString>& customInvalidationProperties, bool hasAlpha)

{

- return new CSSPaintDefinition(scriptState, constructor, paint, nativeInvalidationProperties, customInvalidationProperties);

+ return new CSSPaintDefinition(scriptState, constructor, paint, nativeInvalidationProperties, customInvalidationProperties, hasAlpha);

}

-CSSPaintDefinition::CSSPaintDefinition(ScriptState* scriptState, v8::Local<v8::Function> constructor, v8::Local<v8::Function> paint, Vector<CSSPropertyID>& nativeInvalidationProperties, Vector<AtomicString>& customInvalidationProperties)

+CSSPaintDefinition::CSSPaintDefinition(ScriptState* scriptState, v8::Local<v8::Function> constructor, v8::Local<v8::Function> paint, Vector<CSSPropertyID>& nativeInvalidationProperties, Vector<AtomicString>& customInvalidationProperties, bool hasAlpha)

: m_scriptState(scriptState)

, m_constructor(scriptState->isolate(), constructor)

, m_paint(scriptState->isolate(), paint)

+ , m_didCallConstructor(false)

+ , m_hasAlpha(hasAlpha)

{

m_nativeInvalidationProperties.swap(nativeInvalidationProperties);

m_customInvalidationProperties.swap(customInvalidationProperties);

@@ -56,7 +58,7 @@ PassRefPtr<Image> CSSPaintDefinition::paint(const LayoutObject& layoutObject, co

DCHECK(layoutObject.node());

PaintRenderingContext2D* renderingContext = PaintRenderingContext2D::create(

- ImageBuffer::create(wrapUnique(new RecordingImageBufferSurface(size))));

+ ImageBuffer::create(wrapUnique(new RecordingImageBufferSurface(size, nullptr /* fallbackFactory */, m_hasAlpha ? NonOpaque : Opaque))), m_hasAlpha);

PaintSize* paintSize = PaintSize::create(size);

StylePropertyMap* styleMap = FilteredComputedStylePropertyMap::create(

CSSComputedStyleDeclaration::create(layoutObject.node()),