third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp - Issue 2077413005: Add "alpha" option to PaintWorklet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp

Issue 2077413005: Add "alpha" option to PaintWorklet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set alpha to be true by default Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h ('k') | third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2DTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp

index 2d975bb1e454627005316709a5e8c61bdda62d5f..19884e3b066d248a2f78802413eb28bdc12dbaa5 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp

@@ -9,11 +9,17 @@

namespace blink {

-PaintRenderingContext2D::PaintRenderingContext2D(std::unique_ptr<ImageBuffer> imageBuffer)

- : m_imageBuffer(std::move(imageBuffer))

+PaintRenderingContext2D::PaintRenderingContext2D(std::unique_ptr<ImageBuffer> imageBuffer, bool hasAlpha)

+ : m_imageBuffer(std::move(imageBuffer)), m_hasAlpha(hasAlpha)

{

m_clipAntialiasing = AntiAliased;

modifiableState().setShouldAntialias(true);

+ // RecordingImageBufferSurface doesn't call ImageBufferSurface::clear explicitly.

+ DCHECK(m_imageBuffer);

+ m_imageBuffer->canvas()->clear(hasAlpha ? SK_ColorTRANSPARENT : SK_ColorBLACK);

+ m_imageBuffer->didDraw(FloatRect(0, 0, width(), height()));

}

int PaintRenderingContext2D::width() const