Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2077253002: Introduce password_manager::FormSaver (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@621355_555132_PFM_blacklisted_matches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce password_manager::FormSaver COMMIT=false This is still a WIP. This splits the form saving funcitonality off of PasswordFormManager into FormSaver. The CL also introduces tests for the new class and reduces the corresponding tests for PFM. For more details see the design doc at https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit?usp=sharing BUG=621355

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP: Save & Update in FormSaver roughly done (no tests yet) #

Patch Set 4 : WIP, FormSaver compiles, no tests yet #

Patch Set 5 : WIP: some components_unittests done #

Patch Set 6 : PasswordFormManagerTest.* pass, FormSaver tests not started yet, unit_tests not touched yet #

Patch Set 7 : FormSaver tests added; TODO=tests other than components + clean-up #

Patch Set 8 : Tests should pass now, TODO=clean-up #

Patch Set 9 : Fix Android compile #

Patch Set 10 : Some debug tests fixed, a couple still need fixing #

Patch Set 11 : Debug tests fixed & patch rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1105 lines, -450 lines) Patch
M chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager.gypi View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_password_form_manager.cc View 1 2 3 2 chunks +9 lines, -5 lines 0 comments Download
A components/password_manager/core/browser/form_saver.h View 1 2 3 4 5 6 1 chunk +55 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/form_saver_impl.h View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/form_saver_impl.cc View 1 2 3 4 5 6 1 chunk +111 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/form_saver_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +466 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 2 3 9 chunks +27 lines, -26 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 2 3 4 5 15 chunks +141 lines, -213 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 2 3 4 5 6 7 61 chunks +154 lines, -195 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 2 3 6 chunks +8 lines, -4 lines 0 comments Download
A components/password_manager/core/browser/stub_form_saver.h View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
vabr (Chromium)
WIP
4 years, 6 months ago (2016-06-20 16:05:21 UTC) #1
vabr (Chromium)
WIP: Save & Update in FormSaver roughly done (no tests yet)
4 years, 6 months ago (2016-06-21 12:38:07 UTC) #2
vabr (Chromium)
WIP, FormSaver compiles, no tests yet
4 years, 6 months ago (2016-06-21 13:48:18 UTC) #3
vabr (Chromium)
WIP: some components_unittests done
4 years, 6 months ago (2016-06-21 15:20:19 UTC) #4
vabr (Chromium)
PasswordFormManagerTest.* pass, FormSaver tests not started yet, unit_tests not touched yet
4 years, 6 months ago (2016-06-21 15:54:51 UTC) #5
vabr (Chromium)
FormSaver tests added; TODO=tests other than components + clean-up
4 years, 6 months ago (2016-06-22 12:37:19 UTC) #6
vabr (Chromium)
Tests should pass now, TODO=clean-up
4 years, 6 months ago (2016-06-22 14:16:03 UTC) #7
vabr (Chromium)
Fix Android compile
4 years, 6 months ago (2016-06-22 14:42:08 UTC) #8
vabr (Chromium)
Some debug tests fixed, a couple still need fixing
4 years, 6 months ago (2016-06-22 16:07:26 UTC) #9
vabr (Chromium)
Debug tests fixed & patch rebased
4 years, 6 months ago (2016-06-23 05:59:07 UTC) #10
vabr (Chromium)
4 years, 6 months ago (2016-06-23 09:22:16 UTC) #11 
As this CL got slightly messy through the development process, I filed a new
copy, https://codereview.chromium.org/2090583003, for review, and will close
this one.

Powered by Google App Engine
This is Rietveld 408576698