Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: components/password_manager/core/browser/form_saver_impl.h

Issue 2077253002: Introduce password_manager::FormSaver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_555132_PFM_blacklisted_matches
Patch Set: Debug tests fixed & patch rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/form_saver_impl.h
diff --git a/components/password_manager/core/browser/form_saver_impl.h b/components/password_manager/core/browser/form_saver_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..68553b497e3e06d6170ff506825525f069dfc667
--- /dev/null
+++ b/components/password_manager/core/browser/form_saver_impl.h
@@ -0,0 +1,65 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_FORM_SAVER_IMPL_H_
+#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_FORM_SAVER_IMPL_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "components/password_manager/core/browser/form_saver.h"
+
+namespace password_manager {
+
+class PasswordStore;
+
+// The production code implementation of FormSaver.
+class FormSaverImpl : public FormSaver {
+ public:
+ // |store| needs to outlive |this| and will be used for all PasswordStore
+ // operations.
+ explicit FormSaverImpl(PasswordStore* store);
+
+ ~FormSaverImpl() override;
+
+ // FormSaver:
+ void PermanentlyBlacklist(autofill::PasswordForm* observed) override;
+ void Save(
+ const autofill::PasswordForm& pending,
+ bool is_new_login,
+ const autofill::PasswordFormMap& best_matches,
+ const std::vector<const autofill::PasswordForm*>* credentials_to_update,
+ const autofill::PasswordForm* old_primary_key) override;
+ void PresaveGeneratedPassword(
+ const autofill::PasswordForm& generated) override;
+ void RemovePresavedPassword() override;
+
+ private:
+ // Marks all of |best_matches_| as not preferred unless the username is
+ // |preferred_username|.
+ void UpdatePreferredLoginState();
+
+ // Iterates over all |best_matches| and deletes from the password store all
+ // which are not PSL-matched, have an empty username, and a password equal to
+ // |pending_->password_value|.
+ void DeleteEmptyUsernameCredentials();
+
+ // Cached pointer to the PasswordStore.
+ PasswordStore* const store_;
+
+ // Caches the best matches during a call to Save().
+ const autofill::PasswordFormMap* best_matches_ = nullptr;
+
+ // Caches the pending credential.
+ const autofill::PasswordForm* pending_ = nullptr;
+
+ // Stores the pre-saved credential (happens during password generation).
+ std::unique_ptr<autofill::PasswordForm> presaved_;
+
+ DISALLOW_COPY_AND_ASSIGN(FormSaverImpl);
+};
+
+} // namespace password_manager
+
+#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_FORM_SAVER_IMPL_H_
« no previous file with comments | « components/password_manager/core/browser/form_saver.h ('k') | components/password_manager/core/browser/form_saver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698