components/password_manager/core/browser/BUILD.gn - Issue 2077253002: Introduce password_manager::FormSaver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 2077253002: Introduce password_manager::FormSaver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_555132_PFM_blacklisted_matches

Patch Set: Debug tests fixed & patch rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager.gypi ('k') | components/password_manager/core/browser/credential_manager_password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/BUILD.gn

diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn

index 1001d5eee2a36f6716b53e6ce44a4fc75d523f51..145ad672543833d54126e7775f00173f549f88cc 100644

--- a/components/password_manager/core/browser/BUILD.gn

+++ b/components/password_manager/core/browser/BUILD.gn

@@ -44,6 +44,9 @@ source_set("browser") {

"facet_manager.cc",

"facet_manager.h",

"facet_manager_host.h",

+ "form_saver.h",

+ "form_saver_impl.cc",

+ "form_saver_impl.h",

"import/csv_reader.cc",

"import/csv_reader.h",

"import/password_csv_reader.cc",

@@ -175,6 +178,7 @@ source_set("test_support") {

"mock_password_store.h",

"password_manager_test_utils.cc",

"password_manager_test_utils.h",

+ "stub_form_saver.h",

"stub_log_manager.cc",

"stub_log_manager.h",

"stub_password_manager_client.cc",

@@ -244,6 +248,7 @@ source_set("unit_tests") {

"export/password_csv_writer_unittest.cc",

"export/password_exporter_unittest.cc",

"facet_manager_unittest.cc",

+ "form_saver_impl_unittest.cc",

"import/csv_reader_unittest.cc",

"import/password_csv_reader_unittest.cc",

"import/password_importer_unittest.cc",