chrome/browser/ui/passwords/manage_passwords_test.cc - Issue 2077253002: Introduce password_manager::FormSaver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 2077253002: Introduce password_manager::FormSaver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_555132_PFM_blacklisted_matches

Patch Set: Debug tests fixed & patch rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_test.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc

index 9df501fd39aa8c194738e0bc1774a7875a0911cb..e48aea566feb0a4dfa9e26ed2101434dce2c14e2 100644

--- a/chrome/browser/ui/passwords/manage_passwords_test.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc

@@ -20,6 +20,7 @@

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager_metrics_util.h"

+#include "components/password_manager/core/browser/stub_form_saver.h"

#include "components/password_manager/core/browser/stub_password_manager_client.h"

#include "components/password_manager/core/browser/stub_password_manager_driver.h"

@@ -62,7 +63,8 @@ void ManagePasswordsTest::SetupPendingPassword() {

std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- nullptr, &client, driver.AsWeakPtr(), *test_form(), false));

+ nullptr, &client, driver.AsWeakPtr(), *test_form(), false,

+ base::WrapUnique(new password_manager::StubFormSaver)));

test_form_manager->SimulateFetchMatchingLoginsFromPasswordStore();

ScopedVector<autofill::PasswordForm> best_matches;

test_form_manager->OnGetPasswordStoreResults(std::move(best_matches));

@@ -76,7 +78,8 @@ void ManagePasswordsTest::SetupAutomaticPassword() {

std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- nullptr, &client, driver.AsWeakPtr(), *test_form(), false));

+ nullptr, &client, driver.AsWeakPtr(), *test_form(), false,

+ base::WrapUnique(new password_manager::StubFormSaver)));

GetController()->OnAutomaticPasswordSave(std::move(test_form_manager));

}