DBC: Adds UnarySmiOp instruction, etc.

DBC: Adds UnarySmiOp instruction, etc.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4fae9d3efac61c0557565d05a54c6b374dcc4cac

[zra, 2016-06-16 21:38:02]

zra@google.com changed reviewers:
+ vegorov@google.com

[zra, 2016-06-16 21:38:02]

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_dbc.cc:244: __ PopLocal(locs->out(0).reg());
I guess this might just be masking the underlying problem. I need to get some
other (non-DBC) things started, but I'll return to investigate this after this
CL. If you have time to provide assistance here that would also be appreciated.

[Vyacheslav Egorov (Google), 2016-06-17 08:12:43]

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_dbc.cc:244: __ PopLocal(locs->out(0).reg());
On 2016/06/16 21:38:02, zra wrote:
> I guess this might just be masking the underlying problem. I need to get some
> other (non-DBC) things started, but I'll return to investigate this after this
> CL. If you have time to provide assistance here that would also be
appreciated.

I am looking into this now.

For me flakes seem to occur even with this change, though much more rarely.

[Vyacheslav Egorov (Google), 2016-06-17 11:01:07]

lgtm

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_dbc.cc:244: __ PopLocal(locs->out(0).reg());
I fixed it see a CL I have sent to you. 

You can revert this part.

[zra, 2016-06-21 20:24:08]

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2076773002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_dbc.cc:244: __ PopLocal(locs->out(0).reg());
On 2016/06/17 11:01:07, Vyacheslav Egorov (Google) wrote:
> I fixed it see a CL I have sent to you. 
> 
> You can revert this part.

Done.

[zra, 2016-06-21 20:40:48]

Description was changed from

==========
DBC: Adds UnarySmiOp instruction, etc.
==========

to

==========
DBC: Adds UnarySmiOp instruction, etc.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4fae9d3efac61c0557565d05a54c6b374dcc4cac
==========

[zra, 2016-06-21 20:40:50]

Committed patchset #3 (id:40001) manually as
4fae9d3efac61c0557565d05a54c6b374dcc4cac (presubmit successful).