DBC: Adds UnarySmiOp instruction, etc.

runtime/vm/flow_graph_compiler_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_DBC.
 #if defined(TARGET_ARCH_DBC)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/ast_printer.h"
@@ skipping 221 matching lines @@
   }
   __ PushConstant(dst_type);
   __ PushConstant(dst_name);
   __ AssertAssignable(__ AddConstant(test_cache));
   RecordSafepoint(locs);
   AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id, token_pos);
   if (is_optimizing()) {
     // Assert assignable keeps the instance on the stack as the result,
     // all other arguments are popped.
     ASSERT(locs->out(0).reg() == locs->in(0).reg());
-    __ Drop1();
+    // TODO(zra): __ Drop1() should be sufficient here, but it creates
+    // flakes in checked-mode tests. Need to investigate.
+    __ PopLocal(locs->out(0).reg());

[zra, 2016/06/16 21:38:02]

I guess this might just be masking the underlying problem. I need to get some
other (non-DBC) things started, but I'll return to investigate this after this
CL. If you have time to provide assistance here that would also be appreciated.

[Vyacheslav Egorov (Google), 2016/06/17 08:12:43]

I am looking into this now.

For me flakes seem to occur even with this change, though much more rarely.

[Vyacheslav Egorov (Google), 2016/06/17 11:01:07]

I fixed it see a CL I have sent to you. 

You can revert this part.

[zra, 2016/06/21 20:24:08]

Done.

   }
 }
 
 
 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) {
   if (!is_optimizing()) {
     Definition* defn = instr->AsDefinition();
     if ((defn != NULL) &&
         (defn->tag() != Instruction::kPushArgument) &&
         (defn->tag() != Instruction::kStoreIndexed) &&
@@ skipping 243 matching lines @@
 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
   UNIMPLEMENTED();
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_DBC