Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2076773002: DBC: Adds UnarySmiOp instruction, etc. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Change back to Drop1 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_dbc.cc
diff --git a/runtime/vm/intermediate_language_dbc.cc b/runtime/vm/intermediate_language_dbc.cc
index faf0de95c406956f68a11550c1bcbcf9ef9e636e..d28bbb2c30aff544c47e1e37ad46739edb5d8879 100644
--- a/runtime/vm/intermediate_language_dbc.cc
+++ b/runtime/vm/intermediate_language_dbc.cc
@@ -29,15 +29,13 @@ DECLARE_FLAG(bool, emit_edge_counters);
DECLARE_FLAG(int, optimization_counter_threshold);
// List of instructions that are still unimplemented by DBC backend.
-#define FOR_EACH_UNIMPLEMENTED_INSTRUCTION(M) \
- M(Stop) \
+#define FOR_EACH_UNIMPLEMENTED_INSTRUCTION(M) \
M(IndirectGoto) \
M(LoadCodeUnits) \
M(InstanceOf) \
M(LoadUntagged) \
M(AllocateUninitializedContext) \
M(BinaryInt32Op) \
- M(UnarySmiOp) \
M(UnaryDoubleOp) \
M(SmiToDouble) \
M(Int32ToDouble) \
@@ -48,7 +46,6 @@ DECLARE_FLAG(int, optimization_counter_threshold);
M(DoubleToFloat) \
M(FloatToDouble) \
M(UnboxedConstant) \
- M(CheckEitherNonSmi) \
M(BinaryDoubleOp) \
M(MathUnary) \
M(MathMinMax) \
@@ -219,6 +216,11 @@ void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
+EMIT_NATIVE_CODE(Stop, 0) {
+ __ Stop(message());
+}
+
+
EMIT_NATIVE_CODE(CheckStackOverflow,
0, Location::NoLocation(),
LocationSummary::kCall) {
@@ -914,10 +916,31 @@ EMIT_NATIVE_CODE(CheckSmi, 1) {
}
+EMIT_NATIVE_CODE(CheckEitherNonSmi, 2) {
+ intptr_t left_cid = left()->Type()->ToCid();
+ intptr_t right_cid = right()->Type()->ToCid();
+ const Register left = locs()->in(0).reg();
+ const Register right = locs()->in(1).reg();
+ if (this->left()->definition() == this->right()->definition()) {
+ __ CheckSmi(left);
+ } else if (left_cid == kSmiCid) {
+ __ CheckSmi(right);
+ } else if (right_cid == kSmiCid) {
+ __ CheckSmi(left);
+ } else {
+ __ CheckSmi(left);
+ compiler->EmitDeopt(deopt_id(), ICData::kDeoptBinaryDoubleOp,
+ licm_hoisted_ ? ICData::kHoisted : 0);
+ __ CheckSmi(right);
+ }
+ compiler->EmitDeopt(deopt_id(), ICData::kDeoptBinaryDoubleOp,
+ licm_hoisted_ ? ICData::kHoisted : 0);
+}
+
+
EMIT_NATIVE_CODE(CheckClassId, 1) {
- __ Push(locs()->in(0).reg());
- __ PushConstant(Smi::Handle(Smi::New(cid_)));
- __ IfNeStrictTOS();
+ intptr_t cid = __ AddConstant(Smi::Handle(Smi::New(cid_)));
+ __ CheckClassId(locs()->in(0).reg(), cid);
compiler->EmitDeopt(deopt_id(), ICData::kDeoptCheckClass);
}
@@ -979,6 +1002,22 @@ EMIT_NATIVE_CODE(BinarySmiOp, 2, Location::RequiresRegister()) {
}
}
+
+EMIT_NATIVE_CODE(UnarySmiOp, 1, Location::RequiresRegister()) {
+ switch (op_kind()) {
+ case Token::kNEGATE: {
+ __ Neg(locs()->out(0).reg(), locs()->in(0).reg());
+ compiler->EmitDeopt(deopt_id(), ICData::kDeoptUnaryOp);
+ break;
+ }
+ case Token::kBIT_NOT:
+ __ BitNot(locs()->out(0).reg(), locs()->in(0).reg());
+ break;
+ default:
+ UNREACHABLE();
+ }
+}
+
} // namespace dart
#endif // defined TARGET_ARCH_DBC
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698