Add American Fuzzy Lop (afl) to third_party/afl/

Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
Committed: https://crrev.com/2c059446f38a735223d380a151c281a70e1643ca
Cr-Commit-Position: refs/heads/master@{#401096}

[Jonathan Metzman, 2016-06-17 20:44:54]

Description was changed from

==========
Add American Fuzzy Lop (AFL) to third_party/afl/

1. Put the contents of the root directory of afl-2.14b.tgz in
third_party/afl/src (using the root directory, afl-2.14b/, will mess up
build files).

2. Remove unneeded binary files and their directories:
  * third_party/afl/src/docs/visualization/
  * third_party/afl/src/docs/vuln_samples/
  * third_party/afl/src/testcases/

3. Add README.chromium and OWNERS, and to third_party/afl.

4. Add functioning BUILD.gn to third_party/afl.

5. Remove unnecessary source files that cause git cl's presubmit checks to
fail:
  * third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  * third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc

BUG=
==========

to

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=
==========

[Jonathan Metzman, 2016-06-17 20:44:55]

metzman@google.com changed reviewers:
+ inferno@chromium.org

[inferno, 2016-06-21 14:53:18]

lgtm with nits.

https://codereview.chromium.org/2075883002/diff/40001/third_party/afl/BUILD.gn
File third_party/afl/BUILD.gn (right):

https://codereview.chromium.org/2075883002/diff/40001/third_party/afl/BUILD.g...
third_party/afl/BUILD.gn:5: source_set("afl_runtime") {
s/afl_runtime/afl

https://codereview.chromium.org/2075883002/diff/40001/third_party/afl/BUILD.g...
third_party/afl/BUILD.gn:9: cflags = [ "-Wno-pointer-sign" ]
I think you meant += instead of =

https://codereview.chromium.org/2075883002/diff/40001/third_party/afl/BUILD.g...
third_party/afl/BUILD.gn:11: # These functions should not be compiled with
sanitizers since they
move line 11-12 to before line 14 just like line 16-20 block.

[inferno, 2016-06-21 15:05:50]

inferno@chromium.org changed reviewers:
+ jam@chromium.org

[inferno, 2016-06-21 15:19:19]

lgtm

John - can you please do the owners review. This is used for fuzzing, similar to
libFuzzer in src/third_party.

[jam, 2016-06-21 19:09:14]

On 2016/06/21 15:19:19, inferno wrote:
> lgtm
> 
> John - can you please do the owners review. This is used for fuzzing, similar
to
> libFuzzer in src/third_party.

lgtm

but please add a tracking bug describing this since it seems there's going to be
a series of changes.

i assume this won't link in production code, but just for testing binaries
right?

[Jonathan Metzman, 2016-06-21 19:15:04]

Description was changed from

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=
==========

to

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

[aarya, 2016-06-21 19:16:38]

On 2016/06/21 19:09:14, jam wrote:
> On 2016/06/21 15:19:19, inferno wrote:
> > lgtm
> > 
> > John - can you please do the owners review. This is used for fuzzing,
similar
> to
> > libFuzzer in src/third_party.
> 
> lgtm
> 
> but please add a tracking bug describing this since it seems there's going to
be
> a series of changes.
> 
> i assume this won't link in production code, but just for testing binaries
> right?

Jonathan added the tracking bug. And yes, this is just for testing binaries and
won't link into production code. Also, it is marked "Security Critical: no" for
the same reason.

[aarya, 2016-06-21 19:16:59]

The CQ bit was checked by aarya@google.com

[commit-bot: I haz the power, 2016-06-21 19:17:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075883002/60001

[inferno, 2016-06-21 19:17:26]

The CQ bit was checked by inferno@chromium.org

[inferno, 2016-06-21 19:17:26]

The CQ bit was unchecked by inferno@chromium.org

[inferno, 2016-06-21 19:17:41]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2016-06-21 19:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075883002/60001

[inferno, 2016-06-21 19:30:20]

Description was changed from

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

to

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

[commit-bot: I haz the power, 2016-06-21 20:34:58]

Description was changed from

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

to

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

[commit-bot: I haz the power, 2016-06-21 20:35:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-21 20:37:35]

Description was changed from

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337
==========

to

==========
Add American Fuzzy Lop (afl) to third_party/afl/

Exclude the following unneeded files/directories from afl:
  1. src/docs/visualization/
  2. src/docs/vuln_samples/
  3. src/testcases/
  4. third_party/afl/src/experimental/argv_fuzzing/argv-fuzz-inl.h
  5. third_party/afl/src/llvm_mode/afl-llvm-pass.so.cc
  6. third_party/afl/src/hash.h
  7. third_party/afl/experimental/instrumented_cmp/instrumented_cmp.c

Directories 1-3 contain binary files. We will exclude these files once we start
using DEPS by reorganizing afl upstream so that source files are kept in a
src/ directory. The other directories won't be cloned by DEPS.

Files 4-5 contain includes that cause checkdeps to complain when
git cl presubmit is run. Once we start using DEPS this will be handled
through exclude rules in DEPS.

Files 6-7 do not have license headers and fail checklicenses when
git cl presubmit is run. This will be fixed upstream by adding license headers.

DEPS will be used for afl once it gets a repo.

BUG=611337

Committed: https://crrev.com/2c059446f38a735223d380a151c281a70e1643ca
Cr-Commit-Position: refs/heads/master@{#401096}
==========

[commit-bot: I haz the power, 2016-06-21 20:37:36]

Patchset 4 (id:??) landed as
https://crrev.com/2c059446f38a735223d380a151c281a70e1643ca
Cr-Commit-Position: refs/heads/master@{#401096}