Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2075533002: Menulist SELECT element should update layout when an OPTION content is changed. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Menulist SELECT element should update layout when an OPTION content is changed. r374629 exposed this bug. Before r374629, removing OPTION content triggered style recalc and layout for the SELECT element. Now we need to ask for layout manually. BUG=619837 Committed: https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29 Cr-Commit-Position: refs/heads/master@{#400395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 6 months ago (2016-06-16 12:40:20 UTC) #6
keishi
LGTM
4 years, 6 months ago (2016-06-17 07:27:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075533002/20001
4 years, 6 months ago (2016-06-17 07:43:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-17 08:11:29 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 08:13:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29
Cr-Commit-Position: refs/heads/master@{#400395}

Powered by Google App Engine
This is Rietveld 408576698