Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2075533002: Menulist SELECT element should update layout when an OPTION content is changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 422
423 void HTMLSelectElement::childrenChanged(const ChildrenChange& change) 423 void HTMLSelectElement::childrenChanged(const ChildrenChange& change)
424 { 424 {
425 setRecalcListItems(); 425 setRecalcListItems();
426 setNeedsValidityCheck(); 426 setNeedsValidityCheck();
427 m_lastOnChangeSelection.clear(); 427 m_lastOnChangeSelection.clear();
428 428
429 HTMLFormControlElementWithState::childrenChanged(change); 429 HTMLFormControlElementWithState::childrenChanged(change);
430 } 430 }
431 431
432 void HTMLSelectElement::optionElementChildrenChanged() 432 void HTMLSelectElement::optionElementChildrenChanged(const HTMLOptionElement& op tion)
433 { 433 {
434 setNeedsValidityCheck(); 434 setNeedsValidityCheck();
435 setOptionsChangedOnLayoutObject(); 435 setOptionsChangedOnLayoutObject();
436 436
437 if (layoutObject()) { 437 if (layoutObject()) {
438 if (option.selected() && usesMenuList())
439 layoutObject()->updateFromElement();
438 if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCa che()) 440 if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCa che())
439 cache->childrenChanged(this); 441 cache->childrenChanged(this);
440 } 442 }
441 } 443 }
442 444
443 void HTMLSelectElement::accessKeyAction(bool sendMouseEvents) 445 void HTMLSelectElement::accessKeyAction(bool sendMouseEvents)
444 { 446 {
445 focus(); 447 focus();
446 dispatchSimulatedClick(nullptr, sendMouseEvents ? SendMouseUpDownEvents : Se ndNoEvents); 448 dispatchSimulatedClick(nullptr, sendMouseEvents ? SendMouseUpDownEvents : Se ndNoEvents);
447 } 449 }
(...skipping 1625 matching lines...) Expand 10 before | Expand all | Expand 10 after
2073 } 2075 }
2074 2076
2075 void HTMLSelectElement::didMutateSubtree() 2077 void HTMLSelectElement::didMutateSubtree()
2076 { 2078 {
2077 DCHECK(popupIsVisible()); 2079 DCHECK(popupIsVisible());
2078 DCHECK(m_popup); 2080 DCHECK(m_popup);
2079 m_popup->updateFromElement(PopupMenu::ByDOMChange); 2081 m_popup->updateFromElement(PopupMenu::ByDOMChange);
2080 } 2082 }
2081 2083
2082 } // namespace blink 2084 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698