third_party/WebKit/Source/core/html/HTMLOptionElement.cpp - Issue 2075533002: Menulist SELECT element should update layout when an OPTION content is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

Issue 2075533002: Menulist SELECT element should update layout when an OPTION content is changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option-expected.html ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

index df36b0521d1f9a1ba03cb24f5ef4b1d7548d4637..6c8e8420a37d57dcfaea0030fa9d2a20b106a2be 100644

--- a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

@@ -310,7 +310,7 @@ void HTMLOptionElement::childrenChanged(const ChildrenChange& change)

if (HTMLDataListElement* dataList = ownerDataListElement())

dataList->optionElementChildrenChanged();

else if (HTMLSelectElement* select = ownerSelectElement())

- select->optionElementChildrenChanged();

+ select->optionElementChildrenChanged(*this);

updateLabel();

HTMLElement::childrenChanged(change);

}