Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

Issue 2075533002: Menulist SELECT element should update layout when an OPTION content is changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 5 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
6 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved. 8 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 void HTMLOptionElement::setDirty(bool value) 303 void HTMLOptionElement::setDirty(bool value)
304 { 304 {
305 m_isDirty = true; 305 m_isDirty = true;
306 } 306 }
307 307
308 void HTMLOptionElement::childrenChanged(const ChildrenChange& change) 308 void HTMLOptionElement::childrenChanged(const ChildrenChange& change)
309 { 309 {
310 if (HTMLDataListElement* dataList = ownerDataListElement()) 310 if (HTMLDataListElement* dataList = ownerDataListElement())
311 dataList->optionElementChildrenChanged(); 311 dataList->optionElementChildrenChanged();
312 else if (HTMLSelectElement* select = ownerSelectElement()) 312 else if (HTMLSelectElement* select = ownerSelectElement())
313 select->optionElementChildrenChanged(); 313 select->optionElementChildrenChanged(*this);
314 updateLabel(); 314 updateLabel();
315 HTMLElement::childrenChanged(change); 315 HTMLElement::childrenChanged(change);
316 } 316 }
317 317
318 HTMLDataListElement* HTMLOptionElement::ownerDataListElement() const 318 HTMLDataListElement* HTMLOptionElement::ownerDataListElement() const
319 { 319 {
320 return Traversal<HTMLDataListElement>::firstAncestor(*this); 320 return Traversal<HTMLDataListElement>::firstAncestor(*this);
321 } 321 }
322 322
323 HTMLSelectElement* HTMLOptionElement::ownerSelectElement() const 323 HTMLSelectElement* HTMLOptionElement::ownerSelectElement() const
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 ASSERT(parent); 472 ASSERT(parent);
473 if (isHTMLOptGroupElement(*parent)) { 473 if (isHTMLOptGroupElement(*parent)) {
474 const ComputedStyle* parentStyle = parent->computedStyle() ? parent- >computedStyle() : parent->ensureComputedStyle(); 474 const ComputedStyle* parentStyle = parent->computedStyle() ? parent- >computedStyle() : parent->ensureComputedStyle();
475 return !parentStyle || parentStyle->display() == NONE; 475 return !parentStyle || parentStyle->display() == NONE;
476 } 476 }
477 } 477 }
478 return m_style->display() == NONE; 478 return m_style->display() == NONE;
479 } 479 }
480 480
481 } // namespace blink 481 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698