Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2074273002: [Findit] Add feedback button for manual triage. (Closed)

Created:
4 years, 6 months ago by Sharu Jiang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, chanli, lijeffrey
Base URL:
https://chromium.googlesource.com/infra/infra.git@show-result
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Add feedback button for manual triage. How to go to feedback page. 1. Open the dashboard: https://findit-for-me.googleplex.com/crash/fracas-dashboard 2. Click the signature of a crash, the page will be redirected to the feedback page of this crash. Sheriff can triage 4 results findit provided: regression_range, suspected_cls, suspected_project, suspected_components BUG=615267 Committed: https://chromium.googlesource.com/infra/infra/+/882c793e6442828e2c70c2289215cb155674c13d

Patch Set 1 #

Total comments: 32

Patch Set 2 : Address comments. #

Total comments: 7

Patch Set 3 : Address comments. #

Patch Set 4 : Rebase and fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -19 lines) Patch
M appengine/findit/handlers/crash/fracas_result_feedback.py View 3 chunks +35 lines, -0 lines 0 comments Download
M appengine/findit/handlers/crash/test/fracas_result_feedback_test.py View 4 chunks +37 lines, -0 lines 0 comments Download
A appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
A appengine/findit/handlers/crash/triage_fracas_analysis.py View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M appengine/findit/main.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M appengine/findit/model/crash/crash_analysis.py View 1 4 chunks +25 lines, -12 lines 0 comments Download
M appengine/findit/model/crash/test/crash_analysis_test.py View 1 2 chunks +18 lines, -6 lines 0 comments Download
M appengine/findit/model/triage_status.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M appengine/findit/static/common.css View 1 1 chunk +24 lines, -0 lines 0 comments Download
M appengine/findit/templates/crash/fracas_result_feedback.html View 1 2 7 chunks +214 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (21 generated)
Sharu Jiang
PTAL :)
4 years, 5 months ago (2016-06-29 02:36:07 UTC) #7
Sharu Jiang
PTAL :)
4 years, 5 months ago (2016-06-29 22:43:33 UTC) #9
stgao
Some initial comments, will take a further look at the template. https://codereview.chromium.org/2074273002/diff/120001/appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py File appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py (right): ...
4 years, 5 months ago (2016-06-30 01:28:02 UTC) #11
stgao
https://codereview.chromium.org/2074273002/diff/120001/appengine/findit/templates/crash/fracas_result_feedback.html File appengine/findit/templates/crash/fracas_result_feedback.html (right): https://codereview.chromium.org/2074273002/diff/120001/appengine/findit/templates/crash/fracas_result_feedback.html#newcode20 appengine/findit/templates/crash/fracas_result_feedback.html:20: } How about putting these to the common.css as ...
4 years, 5 months ago (2016-06-30 17:16:41 UTC) #12
Martin Barbella
Deferring to stgao's review here, but I'll try to take a look at the next ...
4 years, 5 months ago (2016-06-30 23:16:42 UTC) #14
Sharu Jiang
https://codereview.chromium.org/2074273002/diff/120001/appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py File appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py (right): https://codereview.chromium.org/2074273002/diff/120001/appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py#newcode1 appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py:1: # Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-01 22:05:49 UTC) #15
stgao
lgtm with nits. https://codereview.chromium.org/2074273002/diff/160001/appengine/findit/handlers/crash/triage_fracas_analysis.py File appengine/findit/handlers/crash/triage_fracas_analysis.py (right): https://codereview.chromium.org/2074273002/diff/160001/appengine/findit/handlers/crash/triage_fracas_analysis.py#newcode59 appengine/findit/handlers/crash/triage_fracas_analysis.py:59: update_data = self.request.params.get('update') should we change ...
4 years, 5 months ago (2016-07-09 01:20:53 UTC) #17
Sharu Jiang
https://codereview.chromium.org/2074273002/diff/160001/appengine/findit/templates/crash/fracas_result_feedback.html File appengine/findit/templates/crash/fracas_result_feedback.html (right): https://codereview.chromium.org/2074273002/diff/160001/appengine/findit/templates/crash/fracas_result_feedback.html#newcode174 appengine/findit/templates/crash/fracas_result_feedback.html:174: $('.triage').click(triageAnalysisResult); On 2016/07/09 01:20:52, stgao wrote: > Are we ...
4 years, 5 months ago (2016-07-11 18:37:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2074273002/200001
4 years, 5 months ago (2016-07-12 23:18:12 UTC) #29
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:20:51 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:200001) as
https://chromium.googlesource.com/infra/infra/+/882c793e6442828e2c70c2289215c...

Powered by Google App Engine
This is Rietveld 408576698