[Findit] Add feedback button for manual triage.

appengine/findit/model/crash/crash_analysis.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
+import json
+import logging
 
 from google.appengine.ext import ndb
 
 from model import analysis_status
 from model import triage_status
 
 
 class CrashAnalysis(ndb.Model):
   """Base class to represent an analysis of a Chrome/Clusterfuzz crash."""
   ################### Properties for the crash itself. ###################
@@ skipping 30 matching lines @@
 
   # When the analysis was completed.
   completed_time = ndb.DateTimeProperty(indexed=False)
 
   # Which version of findit produces this result.
   findit_version = ndb.StringProperty(indexed=False)
 
   ################### Properties for the analysis result. ###################
 
   # Analysis results.
-  result = ndb.JsonProperty(compressed=True, indexed=False, default={})
+  result = ndb.JsonProperty(compressed=True, indexed=False)
 
   # Tags for query and monitoring.
   has_regression_range = ndb.BooleanProperty(indexed=True)
   found_suspects = ndb.BooleanProperty(indexed=True)
   found_project = ndb.BooleanProperty(indexed=True)
   found_components = ndb.BooleanProperty(indexed=True)
 
   solution = ndb.StringProperty(indexed=True)  # 'core', 'blame', etc.
 
   # Triage results.
   regression_range_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
-  culprit_regression_range = ndb.JsonProperty(indexed=False, default=[])
+  culprit_regression_range = ndb.JsonProperty(indexed=False)
 
   suspected_cls_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
-  culprit_cls = ndb.JsonProperty(indexed=False, default=[])
+  culprit_cls = ndb.JsonProperty(indexed=False)
 
   suspected_project_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
-  culprit_project = ndb.JsonProperty(indexed=False, default='')
+  culprit_project = ndb.StringProperty(indexed=False)
 
   suspected_components_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
-  culprit_components = ndb.JsonProperty(indexed=False, default=[])
+  culprit_components = ndb.JsonProperty(indexed=False)
 
   triage_history = ndb.JsonProperty(indexed=False)
 
   # Triage note.
-  note = ndb.StringProperty(indexed=False, default='')
+  note = ndb.StringProperty(indexed=False)
 
   def Reset(self):
     self.pipeline_status_path = None
     self.status = analysis_status.PENDING
     self.requested_time = None
     self.started_time = None
     self.completed_time = None
     self.findit_version = None
     self.has_regression_range = None
     self.found_suspects = None
     self.solution = None
-    self.result = {}
+    self.result = None
     self.regression_range_triage_status = triage_status.UNTRIAGED
-    self.culprit_regression_range = []
+    self.culprit_regression_range = None
     self.suspected_cls_triage_status = triage_status.UNTRIAGED
-    self.culprit_cls = []
+    self.culprit_cls = None
     self.suspected_project_triage_status = triage_status.UNTRIAGED
-    self.culprit_project = ''
+    self.culprit_project = None
     self.suspected_components_triage_status = triage_status.UNTRIAGED
-    self.culprit_components = []
+    self.culprit_components = None
     self.triage_history = None
-    self.note = ''
+    self.note = None
+
+  def Update(self, update):
+    updated = False
+    for key, value in update.iteritems():
+      if not hasattr(self, key):
+        continue
+
+      setattr(self, key, value)
+      updated = True
+
+    return updated
 
   @property
   def completed(self):
     return self.status in (
         analysis_status.COMPLETED, analysis_status.ERROR)
 
   @property
   def failed(self):
     return self.status == analysis_status.ERROR
 
   @property
   def duration(self):
     if not self.completed:
       return None
 
     return int((self.completed_time - self.started_time).total_seconds())