Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5789)

Unified Diff: appengine/findit/model/crash/test/crash_analysis_test.py

Issue 2074273002: [Findit] Add feedback button for manual triage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@show-result
Patch Set: Rebase and fix tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/triage_status.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/crash/test/crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/crash_analysis_test.py b/appengine/findit/model/crash/test/crash_analysis_test.py
index c8ed61d26db65ffcb06e292040d9683d818538d3..f8c711bee5345b291c7c72bd0486a9dfe2731431 100644
--- a/appengine/findit/model/crash/test/crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/crash_analysis_test.py
@@ -68,7 +68,7 @@ class CrashAnalysisTest(unittest.TestCase):
self.assertIsNone(analysis.has_regression_range)
self.assertIsNone(analysis.found_suspects)
self.assertIsNone(analysis.solution)
- self.assertEqual(analysis.result, {})
+ self.assertEqual(analysis.result, None)
self.assertEqual(analysis.regression_range_triage_status,
triage_status.UNTRIAGED)
self.assertEqual(analysis.suspected_cls_triage_status,
@@ -77,9 +77,21 @@ class CrashAnalysisTest(unittest.TestCase):
triage_status.UNTRIAGED)
self.assertEqual(analysis.suspected_components_triage_status,
triage_status.UNTRIAGED)
- self.assertEqual(analysis.culprit_regression_range, [])
- self.assertEqual(analysis.culprit_cls, [])
- self.assertEqual(analysis.culprit_project, '')
- self.assertEqual(analysis.culprit_components, [])
+ self.assertEqual(analysis.culprit_regression_range, None)
+ self.assertEqual(analysis.culprit_cls, None)
+ self.assertEqual(analysis.culprit_project, None)
+ self.assertEqual(analysis.culprit_components, None)
self.assertEqual(analysis.triage_history, None)
- self.assertEqual(analysis.note, '')
+ self.assertEqual(analysis.note, None)
+
+ def testUpdateCrashAnalysis(self):
+ update = {'note': 'dummy'}
+ analysis = CrashAnalysis()
+ analysis.Update(update)
+ self.assertEqual(analysis.note, update['note'])
+
+ def testUpdateCrashAnalysisWithNonExistentProperty(self):
+ update = {'dummy': 'dummy_content'}
+ analysis = CrashAnalysis()
+ analysis.Update(update)
+ self.assertFalse(hasattr(analysis, 'dummy'))
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/triage_status.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698