[Findit] Add feedback button for manual triage.

appengine/findit/model/crash/crash_analysis.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
+import json
+import logging
 
 from google.appengine.ext import ndb
 
 from model import analysis_status
 from model import triage_status
 
 
 class CrashAnalysis(ndb.Model):
   """Base class to represent an analysis of a Chrome/Clusterfuzz crash."""
   ################### Properties for the crash itself. ###################
@@ skipping 51 matching lines @@
   regression_range_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
   culprit_regression_range = ndb.JsonProperty(indexed=False, default=[])
 
   suspected_cls_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
   culprit_cls = ndb.JsonProperty(indexed=False, default=[])
 
   suspected_project_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
-  culprit_project = ndb.JsonProperty(indexed=False, default='')
+  culprit_project = ndb.StringProperty(indexed=False, default='')
 
   suspected_components_triage_status = ndb.IntegerProperty(
       indexed=True, default=triage_status.UNTRIAGED)
   culprit_components = ndb.JsonProperty(indexed=False, default=[])
 
-  triage_history = ndb.JsonProperty(indexed=False)
+  triage_history = ndb.JsonProperty(indexed=False, default=[])

[stgao, 2016/06/30 01:28:02]

We'd better not "hard-code" [] as the default value.

This could cause similar issue as
http://stackoverflow.com/questions/9887180/the-value-of-an-empty-list-in-func...

[Sharu Jiang, 2016/07/01 22:05:48]

Done.

 
   # Triage note.
   note = ndb.StringProperty(indexed=False, default='')
 
   def Reset(self):
     self.pipeline_status_path = None
     self.status = analysis_status.PENDING
     self.requested_time = None
     self.started_time = None
     self.completed_time = None
     self.findit_version = None
     self.has_regression_range = None
     self.found_suspects = None
     self.solution = None
     self.result = {}
     self.regression_range_triage_status = triage_status.UNTRIAGED
     self.culprit_regression_range = []
     self.suspected_cls_triage_status = triage_status.UNTRIAGED
     self.culprit_cls = []
     self.suspected_project_triage_status = triage_status.UNTRIAGED
     self.culprit_project = ''
     self.suspected_components_triage_status = triage_status.UNTRIAGED
     self.culprit_components = []
     self.triage_history = None
     self.note = ''
 
+  def Update(self, update):
+    try:
+      for key, value in update.iteritems():
+        if not hasattr(self, key):
+          continue
+
+        setattr(self, key, value)
+
+      return True
+    except Exception:  # pragma: no cover.

[stgao, 2016/06/30 01:28:02]

Why there will be exceptions here? What kinds of exceptions?

[Sharu Jiang, 2016/07/01 22:05:48]

Just want to return False somehow, changed it to if nothing changed, it will
return False :)

+      logging.warning('Failed to update %s' % json.dumps(update))
+      return False
+
   @property
   def completed(self):
     return self.status in (
         analysis_status.COMPLETED, analysis_status.ERROR)
 
   @property
   def failed(self):
     return self.status == analysis_status.ERROR
 
   @property
   def duration(self):
     if not self.completed:
       return None
 
     return int((self.completed_time - self.started_time).total_seconds())