Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2074213002: mash: Move ash_switches.* to ash/common; cleanup DEPS. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
James Cook, sky, stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, sadrul, asvitkine+watch_chromium.org, tfarina, mlamouri+watch-screen-orientation_chromium.org, achuith+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move ash_switches.* to ash/common; cleanup DEPS. tools/git/move_source_file.py ash/ash_switches* ash/common/ Fix include in ash/virtual_keyboard_controller_unittest.cc. Remove explicit ash_switches.h entry from ash/common/DEPS. BUG=619636 TEST=Compiles, no changes. R=jamescook@chromium.org,sky@chromium.org TBR=stevenjb@chromium.org Committed: https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425 Cr-Commit-Position: refs/heads/master@{#400485}

Patch Set 1 #

Patch Set 2 : Fix broken relative include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -307 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/debug_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/magnifier_key_scroller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/ash_switches.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ash/ash_switches.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M ash/audio/sounds.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + ash/common/ash_switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/ash_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/material_design/material_design_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/material_design/material_design_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/power/tray_power_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_layout_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/root_window_transformers.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_platform_part_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
msw
Please take a look; thanks! James:ash/*, Scott:chrome/* (this is pretty mechanical, feel free to stamp)
4 years, 6 months ago (2016-06-17 18:26:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074213002/20001
4 years, 6 months ago (2016-06-17 18:27:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 19:12:58 UTC) #7
James Cook
rubber stamp LGTM
4 years, 6 months ago (2016-06-17 19:20:32 UTC) #8
sky
Rubber stamp LGTM
4 years, 6 months ago (2016-06-17 19:53:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074213002/20001
4 years, 6 months ago (2016-06-17 20:00:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/202741)
4 years, 6 months ago (2016-06-17 20:09:54 UTC) #13
msw
+TBR stevenjb for chrome/browser/ui/webui/options/* again.
4 years, 6 months ago (2016-06-17 20:12:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074213002/20001
4 years, 6 months ago (2016-06-17 20:12:44 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 20:20:15 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 20:22:07 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425
Cr-Commit-Position: refs/heads/master@{#400485}

Powered by Google App Engine
This is Rietveld 408576698