Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2073683002: [turbofan] The Check and Checked operators don't produce control. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The Check and Checked operators don't produce control. These operators don't need to be part of the control chain. Drive-by-fix: Properly wire the effects during representation selection. R=jarin@chromium.org Committed: https://crrev.com/4d0768dc4b9daed7dec6addedcb8d7d8f5d2dd6c Cr-Commit-Position: refs/heads/master@{#37018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-16 04:38:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the Check/Checked operators. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-16 04:39:54 UTC) #2
Jarin
lgtm. Thanks.
4 years, 6 months ago (2016-06-16 04:44:00 UTC) #3
Jarin
lgtm. Thanks.
4 years, 6 months ago (2016-06-16 04:44:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073683002/1
4 years, 6 months ago (2016-06-16 04:46:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 05:19:09 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 05:19:13 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 05:21:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d0768dc4b9daed7dec6addedcb8d7d8f5d2dd6c
Cr-Commit-Position: refs/heads/master@{#37018}

Powered by Google App Engine
This is Rietveld 408576698