Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2067423003: [turbofan] Properly handle dictionary maps in the prototype chain. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_CheckedOperators
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly handle dictionary maps in the prototype chain. Dictionary prototypes don't have stable maps, but still don't matter for element access. Generalized the JSNativeContextSpecialization a bit to handle everything that Crankshaft can handle in this regard. R=jarin@chromium.org BUG=chromium:616709 Committed: https://crrev.com/1c7bdc7f6f4d9512f4982590bd949f265ee9c8c3 Cr-Commit-Position: refs/heads/master@{#37019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -41 lines) Patch
M src/compilation-dependencies.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compilation-dependencies.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +33 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-616709.js View 1 chunk +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-16 04:53:25 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the prototype chain dictionary maps. Please take a look. ...
4 years, 6 months ago (2016-06-16 04:54:02 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-16 05:10:25 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2073683002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-16 05:11:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067423003/1
4 years, 6 months ago (2016-06-16 05:12:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067423003/1
4 years, 6 months ago (2016-06-16 05:22:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 05:24:40 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 05:24:43 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c7bdc7f6f4d9512f4982590bd949f265ee9c8c3 Cr-Commit-Position: refs/heads/master@{#37019}
4 years, 6 months ago (2016-06-16 05:27:26 UTC) #15
Benedikt Meurer
4 years, 6 months ago (2016-06-16 09:14:42 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2076493002/ by bmeurer@chromium.org.

The reason for reverting is: As discussed offline with Toon, this is not the
correct fix here..

Powered by Google App Engine
This is Rietveld 408576698