src/compiler/simplified-lowering.cc - Issue 2073683002: [turbofan] The Check and Checked operators don't produce control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2073683002: [turbofan] The Check and Checked operators don't produce control. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 628745c711df5707f1cb86eb4070417e559af620..71ff60604b8c7ccd3ea25dc8590f8ea22a42de69 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -1038,7 +1038,7 @@ class RepresentationSelector {

Node* control = NodeProperties::GetControlInput(node);

Node* arith = graph()->NewNode(op, node->InputAt(0), node->InputAt(1));

Node* overflow = graph()->NewNode(common()->Projection(1), arith);

- control = effect =

+ effect =

graph()->NewNode(simplified()->CheckIf(), overflow, effect, control);

Node* value = graph()->NewNode(common()->Projection(0), arith);

« no previous file with comments | « src/compiler/representation-change.cc ('k') | src/compiler/simplified-operator.cc » ('j') | no next file with comments »