Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2075443003: [turbofan] Properly mark the Check/Checked operators are pure. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_CheckedOperators
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly mark the Check/Checked operators are pure. Those operators don't have JavaScript observable side effects and would otherwise block load elimination and other optimizations. R=jarin@chromium.org Committed: https://crrev.com/daf462a61b9c713947f183af996a1c881af14335 Cr-Commit-Position: refs/heads/master@{#37020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/compiler/simplified-operator.cc View 6 chunks +13 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-16 05:07:49 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the baby. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-16 05:08:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075443003/1
4 years, 6 months ago (2016-06-16 05:11:58 UTC) #4
Jarin
lgtm
4 years, 6 months ago (2016-06-16 05:12:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075443003/1
4 years, 6 months ago (2016-06-16 05:22:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 05:35:04 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 05:35:06 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 05:35:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daf462a61b9c713947f183af996a1c881af14335
Cr-Commit-Position: refs/heads/master@{#37020}

Powered by Google App Engine
This is Rietveld 408576698