Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2071563002: [wasm] Make reported "column number" 1-based (Closed)

Created:
4 years, 6 months ago by Clemens Hammacher
Modified:
4 years, 6 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@decode-function-offsets-table
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Make reported "column number" 1-based We report the byte offset as column number, but devtools assumes them to be 1-based and subtracts one unconditionally before further processing it. It's a bit unfortunate, but because of that we have to just add 1 to the reported column number on the public StackTrace API. R=ahaas@chromium.org, titzer@chromium.org BUG=chromium:613110 Committed: https://crrev.com/b16d51efa9111564d7e274376a8839d1886019ec Cr-Commit-Position: refs/heads/master@{#37036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/isolate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/wasm/test-wasm-stack.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Clemens Hammacher
4 years, 6 months ago (2016-06-15 17:44:15 UTC) #1
titzer
On 2016/06/15 17:44:15, Clemens Hammacher wrote: lgtm
4 years, 6 months ago (2016-06-15 18:04:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071563002/1
4 years, 6 months ago (2016-06-16 12:03:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 12:05:03 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 12:07:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b16d51efa9111564d7e274376a8839d1886019ec
Cr-Commit-Position: refs/heads/master@{#37036}

Powered by Google App Engine
This is Rietveld 408576698