src/runtime/runtime-internal.cc - Issue 2071563002: [wasm] Make reported "column number" 1-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-internal.cc

Issue 2071563002: [wasm] Make reported "column number" 1-based (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@decode-function-offsets-table

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-internal.cc

diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc

index 50fb6a45ae4a9e5d9a94c148e83cc0f8b7c9c656..13ba040f1f99dee08fea4b6efb0ffe924f4b4cbe 100644

--- a/src/runtime/runtime-internal.cc

+++ b/src/runtime/runtime-internal.cc

@@ -141,8 +141,9 @@ RUNTIME_FUNCTION(Runtime_ThrowWasmError) {

LookupIterator::PROTOTYPE_CHAIN_SKIP_INTERCEPTOR);

if (it.IsFound()) {

DCHECK(JSReceiver::GetDataProperty(&it)->IsSmi());

+ // Make column number 1-based here.

Maybe<bool> data_set = JSReceiver::SetDataProperty(

- &it, handle(Smi::FromInt(byte_offset), isolate));

+ &it, handle(Smi::FromInt(byte_offset + 1), isolate));

DCHECK(data_set.IsJust() && data_set.FromJust() == true);

USE(data_set);

}

« no previous file with comments | « src/isolate.cc ('k') | test/cctest/wasm/test-wasm-stack.cc » ('j') | no next file with comments »