[wasm] Add functionality to decode a function offset table

[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110
Committed: https://crrev.com/175fc180b717dcac0301b7300eb9ccfa790540f4
Cr-Commit-Position: refs/heads/master@{#37028}

[Clemens Hammacher, 2016-06-09 12:19:16]

Description was changed from

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
==========

to

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110
==========

[titzer, 2016-06-10 11:20:05]

lgtm other than nit

https://codereview.chromium.org/2055783002/diff/40001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2055783002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:308: using ModuleResult = Result<const WasmModule*>;
You can just use a typedef for these, since they are semantically equivalent.
IIUC, this using syntax is only useful when template typedefs are involved.

Let's stick with typedef and if we want to use the "using" syntax, update all of
them at the same time.

[Clemens Hammacher, 2016-06-16 08:14:18]

https://codereview.chromium.org/2055783002/diff/40001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2055783002/diff/40001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:308: using ModuleResult = Result<const WasmModule*>;
On 2016/06/10 11:20:05, titzer wrote:
> You can just use a typedef for these, since they are semantically equivalent.
> IIUC, this using syntax is only useful when template typedefs are involved.
> 
> Let's stick with typedef and if we want to use the "using" syntax, update all
of
> them at the same time.

Done.

[Clemens Hammacher, 2016-06-16 08:14:37]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-06-16 08:14:37]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2055783002/#ps60001
(title: "fix nit")

[commit-bot: I haz the power, 2016-06-16 08:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055783002/60001

[commit-bot: I haz the power, 2016-06-16 08:45:24]

Description was changed from

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110
==========

[commit-bot: I haz the power, 2016-06-16 08:45:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-16 08:46:05]

Description was changed from

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[wasm] Add functionality to decode a function offset table

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110

Committed: https://crrev.com/175fc180b717dcac0301b7300eb9ccfa790540f4
Cr-Commit-Position: refs/heads/master@{#37028}
==========

[commit-bot: I haz the power, 2016-06-16 08:46:06]

Patchset 4 (id:??) landed as
https://crrev.com/175fc180b717dcac0301b7300eb9ccfa790540f4
Cr-Commit-Position: refs/heads/master@{#37028}