src/isolate.cc - Issue 2071563002: [wasm] Make reported "column number" 1-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2071563002: [wasm] Make reported "column number" 1-based (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@decode-function-offsets-table

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 31f51bef93838df80764a60179b1d6a9bb6f7db7..b6c90ba319cd51cd2a3136b728cdd45c504b494a 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -621,6 +621,8 @@ class CaptureStackTraceHelper {

Code* code = frame->LookupCode();

int offset = static_cast<int>(frame->pc() - code->instruction_start());

int position = code->SourcePosition(offset);

+ // Make position 1-based.

+ if (position >= 0) ++position;

JSObject::AddProperty(stack_frame, column_key_,

isolate_->factory()->NewNumberFromInt(position),

NONE);

« no previous file with comments | « no previous file | src/runtime/runtime-internal.cc » ('j') | no next file with comments »