Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2070493003: Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata" (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata" This reverts commit ed1777e4b26643099ef0c24cd53d5c1629850141. This reverts commit f8e3f223476b461d4c9fcf89b691441f73532bf4. Committed: https://github.com/dart-lang/sdk/commit/368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -280 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +18 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 3 chunks +3 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +13 lines, -54 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 4 chunks +37 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 4 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 15 chunks +0 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 6 chunks +1 line, -50 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +7 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 6 chunks +0 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 6 months ago (2016-06-16 08:11:36 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae (presubmit successful).
4 years, 6 months ago (2016-06-16 08:11:59 UTC) #4
Harry Terkelsen
4 years, 6 months ago (2016-06-16 17:48:37 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698