pkg/compiler/lib/src/js_backend/constant_emitter.dart - Issue 2070493003: Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 2070493003: Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

index e88d927fdb8f4c819941282cc2f2106576f21723..fc53cb4158aece420c3232b6661dbebe9d90fc77 100644

--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

@@ -64,11 +64,6 @@ class ConstantEmitter implements ConstantValueVisitor<jsAst.Expression, Null> {

return new jsAst.LiteralNull();

}

- @override

- jsAst.Expression visitNonConstant(NonConstantValue constant, [_]) {

- return new jsAst.LiteralNull();

- }

static final _exponentialRE = new RegExp('^'

'\([-+]?\)' // 1: sign

'\([0-9]+\)' // 2: leading digit(s)

« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart » ('j') | no next file with comments »