Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata"

tests/compiler/dart2js/serialization/equivalence_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.serialization_test;
 
 import 'dart:io';
 import '../memory_compiler.dart';
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/commandline_options.dart';
@@ skipping 230 matching lines @@
 
 /// Check the equivalence of the two lists of elements, [list1] and [list2].
 ///
 /// Uses [object1], [object2] and [property] to provide context for failures.
 checkElementLists(Object object1, Object object2, String property,
                   Iterable<Element> list1, Iterable<Element> list2) {
   checkListEquivalence(object1, object2, property,
                   list1, list2, checkElementProperties);
 }
 
-/// Check the equivalence of the two metadata annotations, [metadata1] and
-/// [metadata2].
-///
-/// Uses [object1], [object2] and [property] to provide context for failures.
-checkMetadata(Object object1, Object object2, String property,
-    MetadataAnnotation metadata1, MetadataAnnotation metadata2) {
-  check(object1, object2, property,
-      metadata1, metadata2, areMetadataAnnotationsEquivalent);
-}
-
 /// Visitor that checks for equivalence of [Element] properties.
 class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
   const ElementPropertyEquivalence();
 
   void visit(Element element1, Element element2) {
     if (element1 == null && element2 == null) return;
     element1 = element1.declaration;
     element2 = element2.declaration;
     if (element1 == element2) return;
     check(element1, element2, 'kind', element1.kind, element2.kind);
     element1.accept(this, element2);
     check(element1, element2, 'isSynthesized',
         element1.isSynthesized, element2.isSynthesized);
     check(element1, element2, 'isLocal',
         element1.isLocal, element2.isLocal);
     check(element1, element2, 'isFinal',
         element1.isFinal, element2.isFinal);
     check(element1, element2, 'isConst',
         element1.isConst, element2.isConst);
     check(element1, element2, 'isAbstract',
         element1.isAbstract, element2.isAbstract);
     check(element1, element2, 'isStatic',
         element1.isStatic, element2.isStatic);
     check(element1, element2, 'isTopLevel',
         element1.isTopLevel, element2.isTopLevel);
     check(element1, element2, 'isClassMember',
         element1.isClassMember, element2.isClassMember);
     check(element1, element2, 'isInstanceMember',
         element1.isInstanceMember, element2.isInstanceMember);
-    checkListEquivalence(element1, element2, 'metadata',
-        element1.metadata, element2.metadata, checkMetadata);
   }
 
   @override
   void visitElement(Element e, Element arg) {
     throw new UnsupportedError("Unsupported element $e");
   }
 
   @override
   void visitLibraryElement(LibraryElement element1, LibraryElement element2) {
     checkElementIdentities(null, null, null, element1, element2);
@@ skipping 133 matching lines @@
         element1, element2, 'rawType',
         element1.rawType, element2.rawType);
     check(element1, element2, 'isObject',
         element1.isObject, element2.isObject);
     checkTypeLists(element1, element2, 'typeVariables',
         element1.typeVariables, element2.typeVariables);
     check(element1, element2, 'isAbstract',
         element1.isAbstract, element2.isAbstract);
     check(element1, element2, 'isUnnamedMixinApplication',
         element1.isUnnamedMixinApplication, element2.isUnnamedMixinApplication);
-    check(element1, element2, 'isProxy',
-        element1.isProxy, element2.isProxy);
-    check(element1, element2, 'isInjected',
-        element1.isInjected, element2.isInjected);
     check(element1, element2, 'isEnumClass',
         element1.isEnumClass, element2.isEnumClass);
     if (element1.isEnumClass) {
       EnumClassElement enum1 = element1;
       EnumClassElement enum2 = element2;
       checkElementLists(enum1, enum2, 'enumValues',
           enum1.enumValues, enum2.enumValues);
     }
     if (!element1.isObject) {
       checkTypes(element1, element2, 'supertype',
@@ skipping 65 matching lines @@
         element1.type, element2.type);
     checkConstants(
         element1, element2, 'constant',
         element1.constant, element2.constant);
     check(element1, element2, 'isTopLevel',
           element1.isTopLevel, element2.isTopLevel);
     check(element1, element2, 'isStatic',
           element1.isStatic, element2.isStatic);
     check(element1, element2, 'isInstanceMember',
           element1.isInstanceMember, element2.isInstanceMember);
-    check(element1, element2, 'isInjected',
-        element1.isInjected, element2.isInjected);
 
     checkElementIdentities(
         element1, element2, 'library',
         element1.library, element2.library);
     checkElementIdentities(
         element1, element2, 'compilationUnit',
         element1.compilationUnit, element2.compilationUnit);
     checkElementIdentities(
         element1, element2, 'enclosingClass',
         element1.enclosingClass, element2.enclosingClass);
@@ skipping 13 matching lines @@
     checkListEquivalence(
         element1, element2, 'parameters',
         element1.parameters, element2.parameters,
         checkElementProperties);
     check(element1, element2, 'isOperator',
           element1.isOperator, element2.isOperator);
     check(
         element1, element2, 'asyncMarker',
         element1.asyncMarker,
         element2.asyncMarker);
-    check(element1, element2, 'isInjected',
-        element1.isInjected, element2.isInjected);
 
     checkElementIdentities(
         element1, element2, 'library',
         element1.library, element2.library);
     checkElementIdentities(
         element1, element2, 'compilationUnit',
         element1.compilationUnit, element2.compilationUnit);
     checkElementIdentities(
         element1, element2, 'enclosingClass',
         element1.enclosingClass, element2.enclosingClass);
@@ skipping 84 matching lines @@
     check(
         element1, element2, 'effectiveTargetType.raw',
         element1.computeEffectiveTargetType(element1.enclosingClass.rawType),
         element2.computeEffectiveTargetType(element2.enclosingClass.rawType),
         areTypesEquivalent);
     checkElementIdentities(element1, element2, 'immediateRedirectionTarget',
         element1.immediateRedirectionTarget,
         element2.immediateRedirectionTarget);
     checkElementIdentities(element1, element2, 'redirectionDeferredPrefix',
         element1.redirectionDeferredPrefix, element2.redirectionDeferredPrefix);
-    check(element1, element2, 'isInjected',
-        element1.isInjected, element2.isInjected);
   }
 
   @override
   void visitAbstractFieldElement(AbstractFieldElement element1,
                                  AbstractFieldElement element2) {
     visit(element1.getter, element2.getter);
     visit(element1.setter, element2.setter);
   }
 
   @override
@@ skipping 99 matching lines @@
   void visitPrefixElement(PrefixElement element1, PrefixElement element2) {
     check(
         element1, element2, 'isDeferred',
         element1.isDeferred, element2.isDeferred);
     checkElementIdentities(
         element1, element2, 'importedLibrary',
         element1.deferredImport, element2.deferredImport);
     // TODO(johnniwinther): Check members.
   }
 }