pkg/compiler/lib/src/js_backend/js_interop_analysis.dart - Issue 2070493003: Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

Issue 2070493003: Revert "Remove Registry from registerMetadataConstant" and "Serialize metadata" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

index e2ebe39130a3b4ea5222bcd94f3abdba770da85f..448f97992225ff4ddf68fdf4c064f58cb67f2812 100644

--- a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

@@ -5,7 +5,6 @@

/// Analysis to determine how to generate code for typed JavaScript interop.

library compiler.src.js_backend.js_interop_analysis;

-import '../common.dart';

import '../constants/values.dart'

show ConstantValue, ConstructedConstantValue, StringConstantValue;

import '../diagnostics/messages.dart' show MessageKind;

@@ -55,8 +54,6 @@ class JsInteropAnalysis {

void processJsInteropAnnotation(Element e) {

for (MetadataAnnotation annotation in e.implementation.metadata) {

- // TODO(johnniwinther): Avoid processing unresolved elements.

- if (annotation.constant == null) continue;

ConstantValue constant =

backend.compiler.constants.getConstantValue(annotation.constant);

if (constant == null || constant is! ConstructedConstantValue) continue;

« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »