chrome/android/java/strings/android_chrome_strings.grd - Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Insert timer functionality Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java ('k') | chrome/browser/android/password_ui_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index cc3fd76d32d12eae15d64f27b3b9c89a20872390..9818fdab124b2776b6135a8d6f5c9db4129d16c8 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -369,6 +369,18 @@ CHAR-LIMIT guidelines:

Unmask password

</message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_USERNAME_COPIED" desc='Text that announces user that the username of a saved account has been copied'>

+ Username copied

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_SITE_COPIED" desc='Text that announces user that the site of a saved account has been copied'>

+ Site copied

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_PASSWORD_COPIED" desc='Text that announces user that the password of a saved account has been copied'>

vabr (Chromium) 2016/07/28 09:44:33 Also: copied -> copied into clipboard (To avoid co

vabr (Chromium) 2016/07/28 09:44:33 nit: announces user -> announces to the user

dozsa 2016/07/28 14:00:32 Done.

+ Password copied

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_SET_LOCK_SCREEN" desc='Text prompting user to set device lock in order to view/copy passwords'>

+ In order to view and copy passwords you must set up a device lock in your device's security settings.

+ </message>