Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/android/password_ui_view_android.cc

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Insert timer functionality Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/password_ui_view_android.cc
diff --git a/chrome/browser/android/password_ui_view_android.cc b/chrome/browser/android/password_ui_view_android.cc
index bc469ea34568d637a02a960b50685d741b66cdbb..68ea684b2a6d97c28f62719bf04323c11c895303 100644
--- a/chrome/browser/android/password_ui_view_android.cc
+++ b/chrome/browser/android/password_ui_view_android.cc
@@ -110,12 +110,14 @@ ScopedJavaLocalRef<jobject> PasswordUIViewAndroid::GetSavedPasswordEntry(
return Java_PasswordUIView_createSavedPasswordEntry(
env,
ConvertUTF8ToJavaString(env, std::string()).obj(),
+ ConvertUTF16ToJavaString(env, base::string16()).obj(),
ConvertUTF16ToJavaString(env, base::string16()).obj());
}
std::string human_readable_origin = GetDisplayOriginForSettings(*form);
return Java_PasswordUIView_createSavedPasswordEntry(
env, ConvertUTF8ToJavaString(env, human_readable_origin).obj(),
- ConvertUTF16ToJavaString(env, form->username_value).obj());
+ ConvertUTF16ToJavaString(env, form->username_value).obj(),
+ ConvertUTF16ToJavaString(env, form->password_value).obj());
}
ScopedJavaLocalRef<jstring> PasswordUIViewAndroid::GetSavedPasswordException(

Powered by Google App Engine
This is Rietveld 408576698