chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java - Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Insert timer functionality Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

index 27a1e58e70519d956456dae6fd85e6d267ed35a1..68335e242fbcacb6403ba282c6252d57ad335030 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

@@ -45,6 +45,7 @@ public class SavePasswordsPreferences extends PreferenceFragment

// Keys for name/password dictionaries.

public static final String PASSWORD_LIST_URL = "url";

public static final String PASSWORD_LIST_NAME = "name";

+ public static final String PASSWORD_LIST_PASSWORD = "password";

// Used to pass the password id into a new activity.

public static final String PASSWORD_LIST_ID = "id";

@@ -154,12 +155,14 @@ public class SavePasswordsPreferences extends PreferenceFragment

PreferenceScreen screen = getPreferenceManager().createPreferenceScreen(getActivity());

String url = saved.getUrl();

String name = saved.getUserName();

+ String password = saved.getPassword();

screen.setTitle(url);

screen.setOnPreferenceClickListener(this);

screen.setSummary(name);

Bundle args = screen.getExtras();

args.putString(PASSWORD_LIST_NAME, name);

args.putString(PASSWORD_LIST_URL, url);

+ args.putString(PASSWORD_LIST_PASSWORD, password);

args.putInt(PASSWORD_LIST_ID, i);

profileCategory.addPreference(screen);

}