Chromium Code Reviews Chromium Code Reviews
Issue
2066813003:
Revert of Implement script-side of callback reactions for Custom Elements V1 (Closed)
DescriptionRevert of Implement script-side of callback reactions for Custom Elements V1 (patchset #6 id:100001 of https://codereview.chromium.org/2060753002/ )
Reason for revert:
Seems to have broken the Linux builder:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/44040
Original issue's description:
> Implement script-side of callback reactions for Custom Elements V1
>
> This patch implements script-side of callback reactions. Abstract
> classes were implemented in a separate CL[1].
>
> Also contains following refactoring:
> 1. Callbacks are stored as v8::Function to make calling them easier.
> 2. m_observedAttribute is moved to the super class
> (CustomElementDefinition) to allow iteratiion.
> 3. The order to Get("observedAttributes") was changed as per the spec
> change[2].
>
> The wpt test failure is a test issue, PR[3] is sent.
>
> [1] https://codereview.chromium.org/2058823002
> [2] https://github.com/whatwg/html/issues/1373
> [3] https://github.com/w3c/web-platform-tests/pull/3175
>
> BUG=594918
>
> Committed: https://crrev.com/4f581ae17af347201ede92b01dc47068ee0cf2d5
> Cr-Commit-Position: refs/heads/master@{#399859}
TBR=dominicc@chromium.org,haraken@chromium.org,foolip@chromium.org,jl@opera.com,kojii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594918
Patch Set 1 #Messages
Total messages: 10 (2 generated)
|
