Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2066813003: Revert of Implement script-side of callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback-ce
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index a1db45a656006e5d441650bb343a64453220c122..e4557102cb35734aa827b46a5aa05a488ffe40ad 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -9,10 +9,7 @@
#include "core/CoreExport.h"
#include "core/dom/custom/CustomElementDescriptor.h"
#include "platform/heap/Handle.h"
-#include "wtf/HashSet.h"
#include "wtf/Noncopyable.h"
-#include "wtf/text/AtomicString.h"
-#include "wtf/text/AtomicStringHash.h"
namespace blink {
@@ -26,8 +23,6 @@
WTF_MAKE_NONCOPYABLE(CustomElementDefinition);
public:
CustomElementDefinition(const CustomElementDescriptor&);
- CustomElementDefinition(const CustomElementDescriptor&,
- const HashSet<AtomicString>&);
virtual ~CustomElementDefinition();
DECLARE_VIRTUAL_TRACE();
@@ -54,14 +49,15 @@
void upgrade(Element*);
- virtual bool hasConnectedCallback() const = 0;
- virtual bool hasDisconnectedCallback() const = 0;
- bool hasAttributeChangedCallback(const QualifiedName&);
+ // TODO(kojii): Change these methods to pure when script-side is implemented.
+ virtual bool hasConnectedCallback() const { return true; }
+ virtual bool hasDisconnectedCallback() const { return true; }
+ virtual bool hasAttributeChangedCallback(const QualifiedName&) const { return true; }
- virtual void runConnectedCallback(Element*) = 0;
- virtual void runDisconnectedCallback(Element*) = 0;
+ virtual void runConnectedCallback(Element*) {}
+ virtual void runDisconnectedCallback(Element*) {}
virtual void runAttributeChangedCallback(Element*, const QualifiedName&,
- const AtomicString& oldValue, const AtomicString& newValue) = 0;
+ const AtomicString& oldValue, const AtomicString& newValue) {}
void enqueueUpgradeReaction(Element*);
void enqueueConnectedCallback(Element*);
@@ -74,13 +70,9 @@
static void checkConstructorResult(Element*, Document&, const QualifiedName&, ExceptionState&);
- HashSet<AtomicString> m_observedAttributes;
-
private:
const CustomElementDescriptor m_descriptor;
ConstructionStack m_constructionStack;
-
- void enqueueAttributeChangedCallbackForAllAttributes(Element*);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698