third_party/WebKit/Source/bindings/core/v8/V8Binding.h - Issue 2066813003: Revert of Implement script-side of callback reactions for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2066813003: Revert of Implement script-side of callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback-ce

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

index f18e9c4a9ed0bc5ad2d016ae31ccb8b69524a40d..e81bdd29998b3d137c3d5cc2807352d5ab37e358 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

@@ -407,13 +407,6 @@

return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string.impl());

}

-inline v8::Local<v8::Value> v8StringOrNull(v8::Isolate* isolate, const AtomicString& string)

- if (string.isNull())

- return v8::Null(isolate);

- return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string.impl());

inline v8::Local<v8::String> v8String(v8::Isolate* isolate, const CompressibleString& string)

{

if (string.isNull())