Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

This CL modified code to make ChromeExtensionChooserDialog::ShowDialog
work for MacViews.

BUG=613638, 577170
Committed: https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2
Cr-Commit-Position: refs/heads/master@{#399760}

[juncai, 2016-06-13 22:13:26]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org, thestig@chromium.org

[juncai, 2016-06-13 22:13:27]

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa

thestig@chromium.org: Please review changes in 
//chrome/browser/ui/views/browser_dialogs_views.cc
//chrome/chrome_browser_ui.gypi

[Robert Sesek, 2016-06-13 22:22:49]

rsesek@chromium.org changed reviewers:
+ tapted@chromium.org

[Robert Sesek, 2016-06-13 22:22:50]

This is more up Trent's alley.

[Lei Zhang, 2016-06-13 22:26:31]

On 2016/06/13 22:22:50, Robert Sesek wrote:
> This is more up Trent's alley.

Ditto, happy to help with the approval process as needed.

[tapted, 2016-06-14 08:49:03]

lgtm

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm (right):

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm:69: return
ChromeExtensionChooserDialog::ShowDialogImpl(chooser_controller);
nit: blank line after

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
(right):

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h:20:
base::scoped_nsobject<ChooserContentViewCocoa> chooserContentViewCocoa_;
I see you need to rename the class to avoid a symbol conflict, but I would
classify renaming chooserContentView_ as "optional". But renaming it is fine
too.

[Lei Zhang, 2016-06-14 18:05:03]

rs lgtm

[juncai, 2016-06-14 18:08:23]

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm (right):

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm:69: return
ChromeExtensionChooserDialog::ShowDialogImpl(chooser_controller);
On 2016/06/14 08:49:03, tapted wrote:
> nit: blank line after

Done.

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
(right):

https://codereview.chromium.org/2065803002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h:20:
base::scoped_nsobject<ChooserContentViewCocoa> chooserContentViewCocoa_;
On 2016/06/14 08:49:03, tapted wrote:
> I see you need to rename the class to avoid a symbol conflict, but I would
> classify renaming chooserContentView_ as "optional". But renaming it is fine
> too.

Done.

[juncai, 2016-06-14 18:10:58]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-06-14 18:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2065803002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-14 18:11:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065803002/60001

[commit-bot: I haz the power, 2016-06-14 18:53:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-14 18:54:00]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 18:55:27]

Description was changed from

==========
Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

This CL modified code to make ChromeExtensionChooserDialog::ShowDialog
work for MacViews.

BUG=613638, 577170
==========

to

==========
Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

This CL modified code to make ChromeExtensionChooserDialog::ShowDialog
work for MacViews.

BUG=613638, 577170

Committed: https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2
Cr-Commit-Position: refs/heads/master@{#399760}
==========

[commit-bot: I haz the power, 2016-06-14 18:55:28]

Patchset 4 (id:??) landed as
https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2
Cr-Commit-Position: refs/heads/master@{#399760}