chrome/browser/ui/views/browser_dialogs_views.cc - Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_dialogs_views.cc

Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/browser_dialogs_views.cc

diff --git a/chrome/browser/ui/views/browser_dialogs_views.cc b/chrome/browser/ui/views/browser_dialogs_views.cc

index 0e8c3bb429086976ac73553ca9fb7febfbab175e..952b90493470f7390f43114bc9e290e7e8e91736 100644

--- a/chrome/browser/ui/views/browser_dialogs_views.cc

+++ b/chrome/browser/ui/views/browser_dialogs_views.cc

@@ -42,8 +42,6 @@ void ChromeDevicePermissionsPrompt::ShowDialog() {

ShowDialogViews();

}

-// TODO(juncai): Move this to the toolkit-views implementation file of this

-// dialog when it is implemented.

void ChromeExtensionChooserDialog::ShowDialog(

ChooserController* chooser_controller) const {

ShowDialogImpl(chooser_controller);

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »