chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h - Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

index c5c43273a20aed027a66b94b49e5c819bcc9806f..14fec0df35f6cb0d37770d73961a5fc798169afa 100644

--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

@@ -9,7 +9,7 @@

#include "base/mac/scoped_nsobject.h"

-@class ChooserContentView;

+@class ChooserContentViewCocoa;

class ChooserController;

class ChooserDialogCocoa;

@@ -17,7 +17,7 @@ class ChooserDialogCocoa;

// of the selected option.

@interface ChooserDialogCocoaController

: NSViewController<NSTableViewDataSource, NSTableViewDelegate> {

- base::scoped_nsobject<ChooserContentView> chooserContentView_;

+ base::scoped_nsobject<ChooserContentViewCocoa> chooserContentView_;

NSTableView* tableView_; // Weak.

NSButton* connectButton_; // Weak.

NSButton* cancelButton_; // Weak.

@@ -55,7 +55,7 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa

- (void)onHelpPressed:(id)sender;

// Gets the |chooserContentView_|. For testing only.

-- (ChooserContentView*)chooserContentView;

+- (ChooserContentViewCocoa*)chooserContentView;

@end