chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm - Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

Issue 2065803002: Make ChromeExtensionChooserDialog::ShowDialog work for MacViews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

index d3d9dd8e4a52ae2bcea14097dbe7a77960b23f2a..19d03b1ddd91d1cce91c64fd9afbd2f0bf0f7525 100644

--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

@@ -10,7 +10,7 @@

#include <vector>

#include "base/strings/utf_string_conversions.h"

-#import "chrome/browser/ui/cocoa/chooser_content_view.h"

+#import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"

#import "chrome/browser/ui/cocoa/cocoa_profile_test.h"

#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"

#import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"

@@ -60,7 +60,7 @@ class ChooserDialogCocoaControllerTest : public CocoaProfileTest {

std::unique_ptr<ChooserDialogCocoa> chooser_dialog_;

ChooserDialogCocoaController* chooser_dialog_controller_;

- ChooserContentView* chooser_content_view_;

+ ChooserContentViewCocoa* chooser_content_view_;

NSTableView* table_view_;

NSButton* connect_button_;

NSButton* cancel_button_;