Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2065113002: [ic] LoadGlobalIC caches PropertyCells in the feedback vector. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] LoadGlobalIC is now able to cache PropertyCells in the feedback vector. The new approach is that instead of compiling custom handlers for every global object's PropertyCell it uses single dispatcher that caches PropertyCells in respective slot of the feedback vector. Currently the new LoadGlobalIC machinery is disabled. This CL also removes unused LoadGlobalViaContext* stuff. BUG=chromium:576312 LOG=Y Committed: https://crrev.com/c170a4c4d52e84617adf0543dccaef3f8c89d044 Cr-Commit-Position: refs/heads/master@{#37002}

Patch Set 1 #

Patch Set 2 : CQ try #

Patch Set 3 : Cleanup LoadGlobalIC call interfaces #

Patch Set 4 : Further cleanup and disable the flag #

Patch Set 5 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -427 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/code-stub-assembler.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 7 chunks +61 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 2 4 chunks +18 lines, -22 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 chunks +32 lines, -13 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 chunks +26 lines, -4 lines 0 comments Download
M src/interface-descriptors.h View 1 2 3 4 chunks +9 lines, -10 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 3 3 chunks +19 lines, -18 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +60 lines, -17 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065113002/20001
4 years, 6 months ago (2016-06-14 16:49:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 17:19:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065113002/40001
4 years, 6 months ago (2016-06-15 08:14:03 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065113002/80001
4 years, 6 months ago (2016-06-15 08:42:55 UTC) #12
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-15 08:45:54 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 09:12:40 UTC) #16
mvstanton
W00t! LGTM.
4 years, 6 months ago (2016-06-15 12:08:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065113002/80001
4 years, 6 months ago (2016-06-15 12:32:17 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-15 12:35:06 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 12:39:24 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c170a4c4d52e84617adf0543dccaef3f8c89d044
Cr-Commit-Position: refs/heads/master@{#37002}

Powered by Google App Engine
This is Rietveld 408576698