Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: src/code-stubs.h

Issue 2065113002: [ic] LoadGlobalIC caches PropertyCells in the feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 3ead577a8a134551b66bd3b35ff3614cce8b76af..a043bc32ba7fe2427d9cafe4ab768c83fa2defd8 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -71,7 +71,6 @@ namespace internal {
V(FastNewStrictArguments) \
V(GrowArrayElements) \
V(KeyedLoadGeneric) \
- V(LoadGlobalViaContext) \
V(LoadScriptContextField) \
V(LoadDictionaryElement) \
V(NameDictionaryLookup) \
@@ -1737,26 +1736,6 @@ class StoreGlobalStub : public HandlerStub {
};
-class LoadGlobalViaContextStub final : public PlatformCodeStub {
- public:
- static const int kMaximumDepth = 15;
-
- LoadGlobalViaContextStub(Isolate* isolate, int depth)
- : PlatformCodeStub(isolate) {
- minor_key_ = DepthBits::encode(depth);
- }
-
- int depth() const { return DepthBits::decode(minor_key_); }
-
- private:
- class DepthBits : public BitField<int, 0, 4> {};
- STATIC_ASSERT(DepthBits::kMax == kMaximumDepth);
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadGlobalViaContext);
- DEFINE_PLATFORM_CODE_STUB(LoadGlobalViaContext, PlatformCodeStub);
-};
-
-
class StoreGlobalViaContextStub final : public PlatformCodeStub {
public:
static const int kMaximumDepth = 15;
@@ -2386,8 +2365,17 @@ class LoadGlobalICTrampolineStub : public LoadICTrampolineTFStub {
const LoadICState& state)
: LoadICTrampolineTFStub(isolate, state) {}
+ void GenerateAssembly(CodeStubAssembler* assembler) const override;
+
Code::Kind GetCodeKind() const override { return Code::LOAD_GLOBAL_IC; }
+ // DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadGlobal);
+ CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
+ if (!FLAG_new_load_global_ic) {
+ return LoadICTrampolineTFStub::GetCallInterfaceDescriptor();
+ }
+ return LoadGlobalDescriptor(isolate());
+ }
DEFINE_CODE_STUB(LoadGlobalICTrampoline, LoadICTrampolineTFStub);
};
@@ -2507,9 +2495,17 @@ class LoadGlobalICStub : public LoadICTFStub {
explicit LoadGlobalICStub(Isolate* isolate, const LoadICState& state)
: LoadICTFStub(isolate, state) {}
+ void GenerateAssembly(CodeStubAssembler* assembler) const override;
+
Code::Kind GetCodeKind() const override { return Code::LOAD_GLOBAL_IC; }
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
+ // DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadGlobalWithVector);
+ CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
+ if (!FLAG_new_load_global_ic) {
+ return LoadICTFStub::GetCallInterfaceDescriptor();
+ }
+ return LoadGlobalWithVectorDescriptor(isolate());
+ }
DEFINE_CODE_STUB(LoadGlobalIC, LoadICTFStub);
};
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698