Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2066763004: [ic] Enable new LoadGlobalIC machinery. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@load-global-ic-shortcut
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Enable new LoadGlobalIC machinery. BUG=chromium:576312 LOG=Y Committed: https://crrev.com/b6aa77d95f1da91407bc10d8d3344293cc7f3383 Cr-Commit-Position: refs/heads/master@{#37006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-15 08:46:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066763004/1
4 years, 6 months ago (2016-06-15 09:02:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 09:31:18 UTC) #7
mvstanton
lgtm
4 years, 6 months ago (2016-06-15 13:13:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066763004/1
4 years, 6 months ago (2016-06-15 13:29:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 13:32:11 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 13:32:12 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6aa77d95f1da91407bc10d8d3344293cc7f3383 Cr-Commit-Position: refs/heads/master@{#37006}
4 years, 6 months ago (2016-06-15 13:33:01 UTC) #14
Benedikt Meurer
4 years, 6 months ago (2016-06-15 17:08:41 UTC) #16
Message was sent while issue was closed.
Nice 2% improvement on sunspider already. Looks promising.

Powered by Google App Engine
This is Rietveld 408576698