Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: src/type-feedback-vector.h

Issue 2065113002: [ic] LoadGlobalIC caches PropertyCells in the feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/s390/interface-descriptors-s390.cc ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-feedback-vector.h
diff --git a/src/type-feedback-vector.h b/src/type-feedback-vector.h
index 8f097dfb1d7f8b04b8b211f92f7b07f633be69e1..c28f26251c2420da830151dee346c3a245ae8c2a 100644
--- a/src/type-feedback-vector.h
+++ b/src/type-feedback-vector.h
@@ -464,11 +464,28 @@ class LoadGlobalICNexus : public FeedbackNexus {
DCHECK_EQ(FeedbackVectorSlotKind::LOAD_GLOBAL_IC, vector->GetKind(slot));
}
+ int ExtractMaps(MapHandleList* maps) const final {
+ // LoadGlobalICs don't record map feedback.
+ return 0;
+ }
+ MaybeHandle<Code> FindHandlerForMap(Handle<Map> map) const final {
+ return MaybeHandle<Code>();
+ }
+ bool FindHandlers(CodeHandleList* code_list, int length = -1) const final {
+ return length == 0;
+ }
+
void ConfigureMegamorphic() override { UNREACHABLE(); }
void Clear(Code* host);
+ // TODO(ishell): remove LoadIC-style mode support.
void ConfigureMonomorphic(Handle<Map> receiver_map, Handle<Code> handler);
+ // PropertyCell shortcut mode.
+ void ConfigureUninitialized() override;
+ void ConfigurePropertyCellMode(Handle<PropertyCell> cell);
+ void ConfigureHandlerMode(Handle<Code> handler);
+
InlineCacheState StateFromFeedback() const override;
};
« no previous file with comments | « src/s390/interface-descriptors-s390.cc ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698