Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2064593003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions. (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, asvitkine+watch_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions. BUG=619289

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix format #

Total comments: 4

Patch Set 4 : address hta's comments #

Patch Set 5 : remove bad formatting from previous PS on (now) unmodified RTCOfferOptions.idl #

Total comments: 2

Patch Set 6 : haraken's comments #

Total comments: 3

Messages

Total messages: 22 (5 generated)
Guido Urdaneta
hi, PTAL
4 years, 6 months ago (2016-06-13 11:26:14 UTC) #3
hta - Chromium
Looks good, but CreateAnswer will want them too. https://codereview.chromium.org/2064593003/diff/40001/third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl File third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl (right): https://codereview.chromium.org/2064593003/diff/40001/third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl#newcode10 third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl:10: // ...
4 years, 6 months ago (2016-06-13 11:32:33 UTC) #4
Guido Urdaneta
https://codereview.chromium.org/2064593003/diff/40001/third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl File third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl (right): https://codereview.chromium.org/2064593003/diff/40001/third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl#newcode10 third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl:10: // TODO(guidou): Remove the offerToReceive fields once transceiver support ...
4 years, 6 months ago (2016-06-13 12:13:10 UTC) #6
hta - Chromium
lgtm
4 years, 6 months ago (2016-06-13 12:17:54 UTC) #7
Guido Urdaneta
japhet@chromium.org: Please review changes in WebKit/Source/core/frame/UseCounter.h and WebKit/public/platform haraken@chromium.org: Please review changes in WebKit/Source/platform tommi@chromium.org: ...
4 years, 6 months ago (2016-06-13 12:26:12 UTC) #9
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-06-13 13:29:24 UTC) #10
haraken
platform/ LGTM https://codereview.chromium.org/2064593003/diff/20002/third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h File third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h (right): https://codereview.chromium.org/2064593003/diff/20002/third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h#newcode26 third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h:26: explicit RTCAnswerOptionsPlatform(int32_t offerToReceiveVideo, int32_t offerToReceiveAudio, bool voiceActivityDetection) ...
4 years, 6 months ago (2016-06-13 14:39:08 UTC) #11
Guido Urdaneta
https://codereview.chromium.org/2064593003/diff/20002/third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h File third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h (right): https://codereview.chromium.org/2064593003/diff/20002/third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h#newcode26 third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h:26: explicit RTCAnswerOptionsPlatform(int32_t offerToReceiveVideo, int32_t offerToReceiveAudio, bool voiceActivityDetection) On 2016/06/13 ...
4 years, 6 months ago (2016-06-13 14:49:55 UTC) #12
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-13 16:22:30 UTC) #13
Guido Urdaneta
+foolip
4 years, 6 months ago (2016-06-14 09:22:14 UTC) #15
Guido Urdaneta
foolip: please review changes in WebKit/public/
4 years, 6 months ago (2016-06-14 09:23:56 UTC) #16
foolip
Last week was BlinkOn, sorry for the delay. This isn't in https://w3c.github.io/webrtc-pc/ but is mentioned ...
4 years, 6 months ago (2016-06-20 08:13:48 UTC) #17
foolip
On 2016/06/13 11:32:33, hta - Chromium wrote: > Looks good, but CreateAnswer will want them ...
4 years, 6 months ago (2016-06-20 08:50:39 UTC) #18
foolip
Filed https://github.com/w3c/webrtc-pc/issues/709
4 years, 6 months ago (2016-06-20 11:33:41 UTC) #19
Guido Urdaneta
will split this CL in two for easier merging.
4 years, 6 months ago (2016-06-20 12:43:37 UTC) #20
hta - Chromium
(minor) https://codereview.chromium.org/2064593003/diff/90001/third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl File third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl (right): https://codereview.chromium.org/2064593003/diff/90001/third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl#newcode12 third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl:12: [countAs=RTCOfferToReceiveVideo] long offerToReceiveVideo; On 2016/06/20 08:13:47, Philip Jägenstedt ...
4 years, 6 months ago (2016-06-20 12:48:12 UTC) #21
Guido Urdaneta
4 years, 6 months ago (2016-06-20 12:49:54 UTC) #22
Closing this in favor of https://codereview.chromium.org/2077323003/ and a
future CL with the counters.

Powered by Google App Engine
This is Rietveld 408576698