third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl - Issue 2064593003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCOfferAnswerOptions.idl

Issue 2064593003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haraken's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | third_party/WebKit/Source/platform/mediastream/RTCAnswerOptionsPlatform.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webrtc-pc/#offer-answer-options	5 // https://w3c.github.io/webrtc-pc/#offer-answer-options

6	6

7 dictionary RTCOfferAnswerOptions {	7 dictionary RTCOfferAnswerOptions {

8 boolean voiceActivityDetection = true;	8 boolean voiceActivityDetection = true;

	9

	10 // TODO(guidou): Deprecate and remove the offerToReceive fields once

	11 // transceiver support becomes available.

	12 [countAs=RTCOfferToReceiveVideo] long offerToReceiveVideo;
	foolip 2016/06/20 08:13:47 countAs is not in https://chromium.googlesource.co countAs is not in https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So... so I would think this wouldn't compile at all, but maybe unknown extended attributes are ignored in this context? hta - Chromium 2016/06/20 12:48:12 Should be "measureAs", I think. Show quoted text On 2016/06/20 08:13:47, Philip Jägenstedt wrote: > countAs is not in > https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So... > so I would think this wouldn't compile at all, but maybe unknown extended > attributes are ignored in this context? Should be "measureAs", I think.
	13 [countAs=RTCOfferToReceiveAudio] long offerToReceiveAudio;

9 };	14 };

OLD	NEW