third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl - Issue 2064593003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCOfferOptions.idl

Issue 2064593003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferAnswerOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix format Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webrtc-pc/#offer-answer-options	5 // https://w3c.github.io/webrtc-pc/#offer-answer-options

6	6

7 dictionary RTCOfferOptions : RTCOfferAnswerOptions {	7 dictionary RTCOfferOptions : RTCOfferAnswerOptions {

8 boolean iceRestart = false;	8 boolean iceRestart = false;

	9

	10 // TODO(guidou): Remove the offerToReceive fields once transceiver support
	hta - Chromium 2016/06/13 11:32:33 We should probably say "deprecate and remove". We should probably say "deprecate and remove". Guido Urdaneta 2016/06/13 12:13:10 Done. Show quoted text On 2016/06/13 11:32:33, hta - Chromium wrote: > We should probably say "deprecate and remove". Done.
	11 // becomes available.

	12 [countAs=RTCOfferOptionsOfferToReceiveVideo] long offerToReceiveVideo;

	13 [countAs=RTCOfferOptionsOfferToReceiveAudio] long offerToReceiveAudio;
	hta - Chromium 2016/06/13 11:32:33 I think these need to be in RTCOfferAnswerOptions I think these need to be in RTCOfferAnswerOptions - answers want them too. And that means we should not call the counters "RTCOfferOptions". What about "RTCOfferToReceiveVideo" and -Audio? Guido Urdaneta 2016/06/13 12:13:10 Done. Show quoted text On 2016/06/13 11:32:33, hta - Chromium wrote: > I think these need to be in RTCOfferAnswerOptions - answers want them too. And > that means we should not call the counters "RTCOfferOptions". > > What about "RTCOfferToReceiveVideo" and -Audio? Done.
9 };	14 };

OLD	NEW