Changed SkLightingShader API to take in a shader as color source

Changed SkLightingShader API to take in a shader as color source

This CL's base is the CL for the same modification, but in the implementation side: https://codereview.chromium.org/2062703003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002

Committed: https://skia.googlesource.com/skia/+/6af677ff8f549751352847ceefda4538236c8a20

[dvonbeck, 2016-06-14 15:25:55]

Description was changed from

==========
Changed SkLightingShader API to take in a shader as color source

BUG=skia:
==========

to

==========
Changed SkLightingShader API to take in a shader as color source

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002
==========

[dvonbeck, 2016-06-14 15:27:03]

Description was changed from

==========
Changed SkLightingShader API to take in a shader as color source

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002
==========

to

==========
Changed SkLightingShader API to take in a shader as color source

This CL's base is the CL for the same modification, but in the implementation
side: https://codereview.chromium.org/2062703003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002
==========

[dvonbeck, 2016-06-14 17:39:43]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-06-21 14:37:30]

lgtm with one include nit.

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
tests/SerializationTest.cpp:8: #include <SkBitmapProcShader.h>
why this top include?

[reed1, 2016-06-21 14:38:41]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-06-21 14:38:42]

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
tests/SerializationTest.cpp:8: #include <SkBitmapProcShader.h>
On 2016/06/21 14:37:30, egdaniel wrote:
> why this top include?

also, use "" instead of <>

[dvonbeck, 2016-06-21 14:47:39]

Fixed redundant include

[dvonbeck, 2016-06-21 14:47:55]

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/2064153002/diff/60001/tests/SerializationTest...
tests/SerializationTest.cpp:8: #include <SkBitmapProcShader.h>
On 2016/06/21 14:38:42, reed1 wrote:
> On 2016/06/21 14:37:30, egdaniel wrote:
> > why this top include?
> 
> also, use "" instead of <>

Done. My bad! I thought I had fixed that.

[robertphillips, 2016-07-06 15:33:13]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-07-06 15:33:13]

Why not land this ?

[robertphillips, 2016-07-06 15:38:16]

lgtm

https://codereview.chromium.org/2064153002/diff/100001/src/core/SkLightingSha...
File src/core/SkLightingShader.h (right):

https://codereview.chromium.org/2064153002/diff/100001/src/core/SkLightingSha...
src/core/SkLightingShader.h:19: public:
"textured by" -> "lit using" ?

[dvonbeck, 2016-07-06 15:53:05]

Changed comment. Will land as soon as
https://codereview.chromium.org/2062703003/ lands and rolls.

https://codereview.chromium.org/2064153002/diff/100001/src/core/SkLightingSha...
File src/core/SkLightingShader.h (right):

https://codereview.chromium.org/2064153002/diff/100001/src/core/SkLightingSha...
src/core/SkLightingShader.h:19: public:
On 2016/07/06 15:38:15, robertphillips wrote:
> "textured by" -> "lit using" ?

Done.

[dvonbeck, 2016-07-11 01:16:46]

The CQ bit was checked by dvonbeck@google.com

[dvonbeck, 2016-07-11 01:16:47]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2064153002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-11 01:16:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 01:38:37]

Description was changed from

==========
Changed SkLightingShader API to take in a shader as color source

This CL's base is the CL for the same modification, but in the implementation
side: https://codereview.chromium.org/2062703003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002
==========

to

==========
Changed SkLightingShader API to take in a shader as color source

This CL's base is the CL for the same modification, but in the implementation
side: https://codereview.chromium.org/2062703003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002

Committed:
https://skia.googlesource.com/skia/+/6af677ff8f549751352847ceefda4538236c8a20
==========

[commit-bot: I haz the power, 2016-07-11 01:38:38]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/6af677ff8f549751352847ceefda4538236c8a20